Skip to content

Bump botframework-directlinejs in all packages/samples - #1544

Merged
Chris Whitten (cwhitten) merged 2 commits into
masterfrom
bump-drectline-final
Dec 28, 2018
Merged

Chris Whitten (cwhitten) merged 2 commits into
masterfrom
bump-drectline-final

Conversation

@cwhitten

Copy link
Copy Markdown
Member

No description provided.

@coveralls

Coveralls (coveralls) commented Dec 26, 2018 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 676

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.148%

Totals Coverage Status
Change from base Build 656: 0.0%
Covered Lines: 730
Relevant Lines: 1447

💛 - Coveralls

@cwhitten

Copy link
Copy Markdown
Member Author

William Wong (@compulim) does this LGTY?

@compulim William Wong (compulim) left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for bumping the package-lock.json. There was a platform bug on NPM side that randomly turned https into http. This will be a helpful fix for that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants