Repository navigation
Prepare the build for tsdown - #6039
Merged
Merged
Conversation
added 7 commits
November 9, 2026 19:30
Eugene (OEvgeny)
marked this pull request as ready for review
November 10, 2026 04:13
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 10, 2026 04:13
William Wong (compulim)
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
Description
Some build checks and tests assume today's tsup/esbuild output, so switching to tsdown would fail them, and the
css-injectcheck also misses a placeholder written as a template literal. This PR makes them correct for both tools and moves the Lightning CSS options into a shared file; the emitted CSS is byte-identical.Design
injectCSSPlugin) rather than@tsdown/css, so both bundlers can importlightningCSSOptions.mjs. It has one user today; moving it now keeps the tsdown pull request to new configs only.Specific Changes
vibe-grepcss-inject.yaml: also matches template literals (no source writes one today, but`@--X--@`would survive an unminified build:injectCSSPluginonly replaces"…")lightningCSSOptions.mjs: Lightning CSS options andremovePreserveReason(), used byesbuildPlugins.mjsapi/src/boot/middleware.ts:typeon theAvatarPolymiddlewareProxyPropsre-exportvibe-greplightning-css.yaml: accepts:has( > …)as well as:has(> …)boot/bundle.html,fluentTheme/simple.html,preact/fluentTheme/simple.html: build tool may betsuportsdown.changelog/<PR#>-<slug>.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed