Repository navigation
Assert the dictating class on the microphone button wrapper in speech recognition tests - #6042
Open
Eugene (OEvgeny) wants to merge 3 commits into
Open
Eugene (OEvgeny) wants to merge 3 commits into
Eugene (OEvgeny) wants to merge 3 commits into
Conversation
added 3 commits
November 9, 2026 21:47
Eugene (OEvgeny)
marked this pull request as ready for review
November 10, 2026 06:38
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
Thomas Durnford (tdurnford)
as code owners
November 10, 2026 06:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
The tests looked for
webchat__microphone-button--dictatingon the inner<button>, but Web Chat puts the class on its wrapper, sotoBe(false)could never fail. They now check the wrapper (.parentElement), asdictating.forcedColors.htmland theuseStartDictate/useStopDictate/useMicrophoneButtonClickhook tests do.Specific Changes
speech/recognition/{abortAfterAudioStart,birdTweet,microphoneNotAllowed,noNetwork,notConfident,silent,stopRecognizingOnMicrophoneButtonClick,stopSynthesizeOnKeyPress,stopSynthesizeWhenKeyPressBeforeSynthesis,unrecognizableSpeech}.html: assert the dictating class on the wrapper; with the class forced on, all 10 now fail (before: all passed)I have added tests and executed them locally
I have added
.changelog/<PR#>-<slug>.mdI have updated documentation
Review Checklist
z-index)package.jsonandpackage-lock.jsonreviewed