Repository navigation
Desktop testing: enforce session input policy - #4468
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Finish part 1 of the input-lane work started in f5a90cd. Cases declare how they run with desktopIt, and a run selects the cases that apply to its input lane, platform and scope and accounts for everything it excludes. desktop-driver - Add pure case selection and click-mode resolution, and move the requirement preflight and click-mode helpers here. - Add the authoring/input leaf export so config-loading code can import scope helpers from source without the authoring index. desktop-test - Report the lane: a lane run is incomplete when it has skipped or undeclared-unsupported results, an empty selection or nothing executed. - Add the Jasmine adapter (desktop-test/jasmine) with desktopIt and desktopDescribe, plus config-level test scopes and --input. storybook-desktop - Add --input accessible|physical to storybook test, driver and smoke. The lane comes from the flag, DESKTOP_INPUT or the attached driver. - Select cases before they run, resolve declared gaps, assess each cohort, and reject direct input calls in declared cases at extraction. - Fail closed when an accessible lane attaches to a driver that does not mask keyboard, physical click and wheel input. native-core and apps/E2E - Migrate the native-core Callout and FocusZone tests and ButtonV1.spec.win.ts to desktopIt. Update the package references and add patch changesets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace remaining component story runtime skips with desktopIt requirements, platform scopes and declared gaps. Carry the Win32 preview fixes from #4431 and split accessible and advisory physical Storybook CI lanes without changing aggregate PR requirements. Co-authored-by: Srividya Ramaswamy <sriramas@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Integrate merged phase 1 (#4464) and the package-version release without rewriting phase 2 history. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve the runtime contract and update the Win32 preview test for connection epochs and selection sequences. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Vladimir Morozov (vmoroz)
approved these changes
Nov 7, 2026
…tive into user/jasonvmo/input-selection-3
Jason Morse (JasonVMo)
enabled auto-merge (squash)
November 8, 2026 09:16
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Builds on merged #4466 and now targets
main.accessible,physical, or compatibility input policy per WebDriver session, including raw routes and agent actions.setValuebefore its clear step in accessible sessions.Serialized
--input alland managed macOS CI lanes remain follow-up work.Verification
On main-integrated commit
7475d87c1:yarn clean-lage-cache && yarn lage buildci(178 tasks).yarn format,yarn lint, andyarn buildinpackages/agentic/storybook-desktop.yarn test wdioRunner --runInBandin Storybook desktop (1 passed, including absolute/network-path rejection).yarn test --runInBandin Storybook desktop (318 passed, 2 skipped).e93f977fc, with driver code unchanged since:yarn change:check; desktop-driveryarn format,yarn lint, andyarn build;FURN_DESKTOP_DRIVER_DISABLED_INPUT_FEATURES=keyboard,physicalClick,wheel yarn test NativeDesktopHost.input --runInBand(4 passed; 2 failed before the fixture fix); andFURN_DESKTOP_DRIVER_DISABLED_INPUT_FEATURES=keyboard,physicalClick,wheel yarn test --runInBand(876 passed, 61 skipped).yarn lage test-links --verbose --groupedon the main-integrated tree, exclusively from GitHub HTTP 504 responses; no 404 or missing local link was reported. Hosted transient failures will be retried after the current run finishes.Historical native evidence at
9d3e11516:FURN_NATIVE_DRIVER_TEST=1 yarn test --runInBandin desktop-driver passed (894 passed, 43 skipped; ad hoc signing). That is not native qualification of the newer head. Local Windows/Win32 native qualification and stable-signing macOS TCC continuity were not run.At
7475d87c1, CodeQL (including the separate alert check) passes. All platform and Storybook jobs passed in run42468751459, including macOS Paper and both Win32 input lanes. Only the link job and its dependent aggregate remain failed. Repeated retries hit GitHub HTTP 504s; the latest failed downloading Ruby before checking links. Monitoring continues at 30-minute intervals, without changing valid links or relaxing checks.setValuecould clear before a rejected keyboard write.setValuerejects before clearing.Pull request checklist
This PR has considered (when applicable):