Repository navigation
Improve desktop-test and storybook-desktop logging output - #4470
Open
Jason Morse (JasonVMo) wants to merge 1 commit into
Open
Jason Morse (JasonVMo) wants to merge 1 commit into
Jason Morse (JasonVMo) wants to merge 1 commit into
Conversation
Add runDesktopOperation for grouped, collapsed-on-success operation output, add smoke-test run summaries, and replace stop-commands fencing with per-line workflow-command neutralization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9305975d-a017-4007-beb2-68a4684cbbc4
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Reworks console output for
desktop-test,desktop-driverconsumers andstorybook-desktopso it is readable in GitHub Actions and locally. Verdicts and exit codes are unchanged; this is presentation only.runDesktopOperationprints a✔/✖ label (duration): summaryheader. Locally the operation's full output is shown only on failure (an excerpt plusFull log:path) or with--verbose. In GitHub Actions a passing operation is a collapsed::group::, and a failing one is expanded with::errorannotations.N of M story tests executed: X passed, Y failed, Z skipped...(orno story tests executed (0 of N)), the render step reportsN stories rendered, and a fail-fast stop appendsstopped early; K of S stories not run.::stop-commands::***fences,[command-<uuid>]tags and blank lines are gone. Workflow commands in captured output are neutralized per line in all modes (::at line start becomes: :,##[becomes# #[).Call-outs:
--verbose; output is kept in per-command logs.[desktop]line form changed. Non-verbose mode has no start/artifact lines or passed-test lines.pod install) and services are labeled by id.describeWdioCountsnow includes a failed count.@rnx-kit/reporterwas dropped from desktop-test (still used byscripts/).runDesktopOperation,scope-endsummary).Verification
::stop-commands::***fences with GUID tags; inconsistent smoke summariesCommands run (all passed):
yarn formatandyarn lintin desktop-test and storybook-desktopyarn oxfmt --check,yarn check-agent-instructions,yarn install --immutable --mode=skip-buildyarn lage test-links: 90 tasks, 0 failedyarn clean-lage-cachethenyarn lage buildci: 178 succeeded, 0 failedyarn change:check: passedNot run: native macOS/Windows end-to-end runs and a real GitHub Actions run, so the Actions grouping is covered by unit tests only.
Pull request checklist
yarn change