Skip to content

Apply --storage-type when creating a Recovery Services vault - #3982

Open
Federico Laurianti (Laurianti) wants to merge 1 commit into
microsoft:mainfrom
Laurianti:fix-rsv-vault-create-storage-type
Open

Federico Laurianti (Laurianti) wants to merge 1 commit into
microsoft:mainfrom
Laurianti:fix-rsv-vault-create-storage-type

Conversation

@Laurianti

Copy link
Copy Markdown

What does this PR do?

azurebackup vault create --vault-type rsv now applies --storage-type. After the vault is created, the redundancy is set through the backup storage config, the same way azurebackup vault update --redundancy does for RSV vaults. Without --storage-type the requests are unchanged.

Added CreateVaultAsync_RsvWithStorageType_ConfiguresStorageRedundancy to VaultCreateExistenceTests. It fails without the fix: only the vault GET and PUT are sent.

GitHub issue number?

Fixes #3981

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions (excluding Fabric MCP tools), ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution Federico Laurianti (@Laurianti)! We will review the pull request and get back to you soon.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused fix reuses existing behavior, preserves requests when the option is omitted, and includes targeted regression coverage.

No open issues 🎉

What changed in this PR

Fixes #3981 by applying --storage-type when creating Recovery Services vaults through Azure Backup.

Changes:

  • Reuses existing storage redundancy configuration after vault creation.
  • Adds regression coverage for the configuration requests and payload.
  • Records the fix in the changelog.
File Description
tools/​Azure.Mcp.Tools.AzureBackup/​tests/​Azure.Mcp.Tools.AzureBackup.Tests/​Services/​VaultCreateExistenceTests.cs Verifies requested redundancy is sent.
tools/​Azure.Mcp.Tools.AzureBackup/​src/​Services/​RsvBackupOperations.cs Applies storage redundancy when specified.
servers/​Azure.Mcp.Server/​changelog-entries/​1792353214661.yaml Documents the bug fix.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] azurebackup vault create ignores --storage-type for Recovery Services vaults

2 participants