Repository navigation
Apply --storage-type when creating a Recovery Services vault - #3982
Open
Federico Laurianti (Laurianti) wants to merge 1 commit into
Open
Federico Laurianti (Laurianti) wants to merge 1 commit into
Federico Laurianti (Laurianti) wants to merge 1 commit into
Conversation
Federico Laurianti (Laurianti)
requested a review
from a team
as a code owner
October 19, 2026 01:45
Federico Laurianti (Laurianti)
requested review from
KarishmaGhiya,
Rick Winter (RickWinter),
Chidozie Ononiwu (chidozieononiwu),
Connie Yau (conniey),
Jair Myree (jairmyree),
Steven Vukelich (vukelich) and
Jeff Fisher (xirzec)
and
a balanced review from Copilot
October 19, 2026 01:45
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Thank you for your contribution Federico Laurianti (@Laurianti)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix reuses existing behavior, preserves requests when the option is omitted, and includes targeted regression coverage.
No open issues 🎉
What changed in this PR
Fixes #3981 by applying --storage-type when creating Recovery Services vaults through Azure Backup.
Changes:
- Reuses existing storage redundancy configuration after vault creation.
- Adds regression coverage for the configuration requests and payload.
- Records the fix in the changelog.
| File | Description |
|---|---|
| tools/Azure.Mcp.Tools.AzureBackup/tests/Azure.Mcp.Tools.AzureBackup.Tests/Services/VaultCreateExistenceTests.cs | Verifies requested redundancy is sent. |
| tools/Azure.Mcp.Tools.AzureBackup/src/Services/RsvBackupOperations.cs | Applies storage redundancy when specified. |
| servers/Azure.Mcp.Server/changelog-entries/1792353214661.yaml | Documents the bug fix. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
azurebackup vault create --vault-type rsvnow applies--storage-type. After the vault is created, the redundancy is set through the backup storage config, the same wayazurebackup vault update --redundancydoes for RSV vaults. Without--storage-typethe requests are unchanged.Added
CreateVaultAsync_RsvWithStorageType_ConfiguresStorageRedundancytoVaultCreateExistenceTests. It fails without the fix: only the vault GET and PUT are sent.GitHub issue number?
Fixes #3981
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline