Repository navigation
prim.c: prefer Emscripten's implementation over WASI - #1455
Merged
Daan (daanx) merged 1 commit intoOct 24, 2026
Merged
Conversation
Fixes a regression introduced in commit f72b7a0.
Collaborator
|
Thank you! I will try to include emscripten in the test workflow to hopefully prevent this in the future. |
Kleis Auke Wolthuizen (kleisauke)
deleted the
dev3-prefer-emscripten-over-wasi
branch
October 24, 2026 17:50
Daan (daanx)
added a commit
that referenced
this pull request
Oct 25, 2026
…ing to less memory usage); allow environment variables from emscripten, see also issue #1455
Daan (daanx)
added a commit
that referenced
this pull request
Oct 25, 2026
Techcable
pushed a commit
to Techcable/mimalloc
that referenced
this pull request
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in commit f72b7a0.
That commit moved the include directives before platform selection, i.e.:
which causes
mimalloc/heap/init.hto transitively includemimalloc/decl.h, which defines__wasi__for Emscripten builds.mimalloc/include/mimalloc/decl.h
Lines 106 to 108 in b18ab4e
This consequently selects the WASI backend when building with Emscripten. Fix this by preferring Emscripten's implementation instead.