Repository navigation

Update the code base to use IFileSystem instead of fs and fs-extra. - #7915

Merged

Eric Snow (ericsnowcurrently) merged 58 commits into

microsoft:masterfrom

ericsnowcurrently:consolidate-fs-usage

Nov 26, 2019

Merged

Update the code base to use IFileSystem instead of fs and fs-extra.#7915
Eric Snow (ericsnowcurrently) merged 58 commits into
microsoft:masterfrom
ericsnowcurrently:consolidate-fs-usage

Commits on Nov 26, 2019
- Get some errant system tests working with the system Python on Ubuntu.
  Eric Snow (ericsnowcurrently)
  committed
  0eec1f3
- Do not depend on IFileSystem in the old debug adapter.
  Eric Snow (ericsnowcurrently)
  committed
  72b2254
- Excise IPlatformService from the old debug adapter.
  Eric Snow (ericsnowcurrently)
  committed
  8e3af6f
- Group the FileSystem methods by category (and drop 2 unused methods).
  Eric Snow (ericsnowcurrently)
  committed
  24abfc4
- fs -> fsextra.
  Eric Snow (ericsnowcurrently)
  committed
  5326edf
- fileSystem -> fs.
  Eric Snow (ericsnowcurrently)
  committed
  f0044ad
- objectExists() -> pathExists().
  Eric Snow (ericsnowcurrently)
  committed
  6f41c9f
- Drop appendFileSync().
  Eric Snow (ericsnowcurrently)
  committed
  dc0ee44
- Drop unneeded "options" param from writeFile().
  Eric Snow (ericsnowcurrently)
  committed
  9dc2b06
- Add some type aliases.
  Eric Snow (ericsnowcurrently)
  committed
  532d544
- Make methods properly async.
  Eric Snow (ericsnowcurrently)
  committed
  8f27657
- Clean up formatting and parameter names.
  Eric Snow (ericsnowcurrently)
  committed
  352a175
- Add the isDirReadonly() method.
  Eric Snow (ericsnowcurrently)
  committed
  c7b7c5d
- Use IFileSystem.pathExists() (almost) everywhere.
  Eric Snow (ericsnowcurrently)
  committed
  f617d71
- Stop using fs-extra outside of the FileSystem class.
  Eric Snow (ericsnowcurrently)
  committed
  aad400a
- Stop using fs outside of the FileSystem class (mostly).
  Eric Snow (ericsnowcurrently)
  committed
  7ea1b4b
- Drop IPlatformService as a dependency of FileSystem.
  Eric Snow (ericsnowcurrently)
  committed
  de5f872
- Require strict mode.
  Eric Snow (ericsnowcurrently)
  committed
  e3b3623
- Fix some tests.
  Eric Snow (ericsnowcurrently)
  committed
  ad0f857
- Add a mock vscode enum.
  Eric Snow (ericsnowcurrently)
  committed
  2fdc481
- Factor out IRawFileSystem.
  Eric Snow (ericsnowcurrently)
  committed
  4a66d39
- Factor out IFileSystemUtils.
  Eric Snow (ericsnowcurrently)
  committed
  a9fdb35
- Drop an outdated tslint comment.
  Eric Snow (ericsnowcurrently)
  committed
  7dbb147
- Drop an entire unused module.
  Eric Snow (ericsnowcurrently)
  committed
  db3b9ac
- Simplify lookForInterpretersInDirectory().
  Eric Snow (ericsnowcurrently)
  committed
  b32b054
- Drop an unused variable.
  Eric Snow (ericsnowcurrently)
  committed
  9eb24f2
- Make the existing filesystem tests "functional".
  Eric Snow (ericsnowcurrently)
  committed
  1acf2ff
- Add unit tests (and make dependencies explicit).
  Eric Snow (ericsnowcurrently)
  committed
  71c1d54
- Add functional tests.
  Eric Snow (ericsnowcurrently)
  committed
  67eafb0
- Drop unnecessary error handling.
  Eric Snow (ericsnowcurrently)
  committed
  36d41d7
- Fix a shadowed name.
  Eric Snow (ericsnowcurrently)
  committed
  957eb0f
- Pass "path" to the RawFileSystem ctor.
  Eric Snow (ericsnowcurrently)
  committed
  00d8a50
- Factor out TempFileSystem.
  Eric Snow (ericsnowcurrently)
  committed
  baa350b
- Use TempFileSystem in FileSystemUtils.isDirReadonly().
  Eric Snow (ericsnowcurrently)
  committed
  d97b96b
- Update a log message.
  Eric Snow (ericsnowcurrently)
  committed
  7b5562f
- Make test setup more clear.
  Eric Snow (ericsnowcurrently)
  committed
  0100179
- Drop a superfluous check in a test.
  Eric Snow (ericsnowcurrently)
  committed
  39f7353
- Use the temp dir callback during test cleanup.
  Eric Snow (ericsnowcurrently)
  committed
  030156e
- Use tmpDir.removeCallback() during test cleanup.
  Eric Snow (ericsnowcurrently)
  committed
  aa00bc5
- Use skips for platform-specific tests.
  Eric Snow (ericsnowcurrently)
  committed
  97d190a
- Fix a typo.
  Eric Snow (ericsnowcurrently)
  committed
  7176ec1
- Simplify some test setup.
  Eric Snow (ericsnowcurrently)
  committed
  5bb137d
- Be more explicit about expected args in a mock.
  Eric Snow (ericsnowcurrently)
  committed
  826a9a2
- Fix the tmp FS tests.
  Eric Snow (ericsnowcurrently)
  committed
  abce7e8
- Add a test for reading bogus files.
  Eric Snow (ericsnowcurrently)
  committed
  5a023b3
- Use assertions for checking if files exist (or don't).
  Eric Snow (ericsnowcurrently)
  committed
  c8cb26f
- Add missing doc comments.
  Eric Snow (ericsnowcurrently)
  committed
  74564a7
- Drop an unused interface method.
  Eric Snow (ericsnowcurrently)
  committed
  32243b6
- Do not provide defaults in the constructors.
  Eric Snow (ericsnowcurrently)
  committed
  1f8e46f
- Make inversify happy about the FileSystem class.
  Eric Snow (ericsnowcurrently)
  committed
  0f137f0
- Drop dead comments.
  Eric Snow (ericsnowcurrently)
  committed
  784a241
- Use util.promisify() for glob().
  Eric Snow (ericsnowcurrently)
  committed
  242c1ee
- Drop a dead comment.
  Eric Snow (ericsnowcurrently)
  committed
  e3cf740
- Drop some whitespace.
  Eric Snow (ericsnowcurrently)
  committed
  97e5278
- Use normal import for chai-as-promised.
  Eric Snow (ericsnowcurrently)
  committed
  bde62a3
- Fix how some tests are skipped.
  Eric Snow (ericsnowcurrently)
  committed
  7bbd06a
- Drop pathExistsSync().
  Eric Snow (ericsnowcurrently)
  committed
  1dd4d09
- Fix typos and clarify comments.
  Eric Snow (ericsnowcurrently)
  committed
  5eb00e1

Commits

Commits on Nov 26, 2019