Repository navigation
fix(toml): decode local date, time and datetime values - #2923
Open
TheNetherWatcher wants to merge 1 commit into
Open
TheNetherWatcher wants to merge 1 commit into
TheNetherWatcher wants to merge 1 commit into
Conversation
Owner
Owner
|
Not super happy with this - as it means the values no longer roundtrip. AFAIK we can use the timestamp tag without having a specified timezone.... |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2922
TOML local dates, times and date-times (
1979-05-27,07:32:00,1979-05-27T07:32:00) made the decoder fail withunsupported type. They have no timezone, so they are now read as string scalars holding the original text instead of inventing one. Offset date-times are unchanged.Added decode tests for all three. The new tests fail without the fix (
unsupported type LocalDate/LocalTime/LocalDateTime) and pass with it.TestJSONScenariosalso fails on a clean master checkout, so it is not related to this change.