Skip to content

ci: run checks on pull requests instead of pushes - #24

Merged
mridang merged 3 commits into
masterfrom
ci/run-checks-on-pull-request
Nov 12, 2026
Merged

mridang merged 3 commits into
masterfrom
ci/run-checks-on-pull-request

Conversation

@mridang

@mridang mridang commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Description

This pull request introduces the pull_request trigger in place of the push trigger for the CI check workflows (lint, format check, test, dependency checks and similar). Release, deployment and end-to-end workflows are not changed.

Related Issue

Closes #23

Motivation and Context

A check that runs on the push event of a branch tests only that branch, so a pull request can pass while master has moved on and then fail after the merge. The pull_request event tests the merge result of the branch with master, which is what actually lands, so a green pull request now means a green master. The checks are unchanged apart from the trigger, so their names and required status checks keep working.

How Has This Been Tested?

The changed workflows run on this pull request itself, and the pull request is only merged once they are green.

Documentation:

Not applicable.

Checklist:

  • I have updated the documentation accordingly.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@mridang mridang self-assigned this Nov 11, 2026
@mridang
mridang merged commit 75de698 into master Nov 12, 2026
3 of 4 checks passed
@mridang
mridang deleted the ci/run-checks-on-pull-request branch November 12, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI checks run on branch pushes and can pass before master moves on

1 participant