Repository navigation
ci: run checks on pull requests instead of pushes - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the pull_request trigger in place of the push trigger for the CI check workflows (lint, format check, test, dependency checks and similar). Release, deployment and end-to-end workflows are not changed.
Related Issue
Closes #23
Motivation and Context
A check that runs on the push event of a branch tests only that branch, so a pull request can pass while master has moved on and then fail after the merge. The pull_request event tests the merge result of the branch with master, which is what actually lands, so a green pull request now means a green master. The checks are unchanged apart from the trigger, so their names and required status checks keep working.
How Has This Been Tested?
The changed workflows run on this pull request itself, and the pull request is only merged once they are green.
Documentation:
Not applicable.
Checklist: