Repository navigation
Make .fppi changes trigger re-generation - #3933
Merged
Merged
Conversation
thomas-bc
approved these changes
Jul 24, 2025
LeStarch
pushed a commit
that referenced
this pull request
Aug 4, 2026
Covers #3929. TestRelative gains an included.fppi consumed by constant2.fpp, and records its CMAKE_CONFIGURE_DEPENDS so the tests can assert the include is registered as a configure dependency and that touching it re-runs CMake. Asserting on generated content instead would pass with the fix in #3933 reverted, because the include already reaches the generation command through FILE_DEPENDENCIES. The configure dependency is the part that regresses silently. Co-authored-by: Kadir Can Yildirim <252162627+kadircanyildirm-crypto@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes: #3928