add CODENAMES.md by Trott · Pull Request #318 · nodejs/Release

Trott · 2018-03-31T06:19:46Z

Fixes: #317

tunnckoCore · 2018-03-31T07:49:43Z

Only left, writers of articles to use them ;d

richardlau

I wonder if we should add the existing names (i.e., Argon, Boron, and Carbon)? Otherwise by implication we should remember to update this list to delete, e.g., Dubnium when 10.x goes LTS?

jasnell

Are these just suggestions at this point? How was the list come up with? I'm afraid I may have missed something being disconnected a bit over the previous week. I'd like to review this and think about the naming a bit more before this lands.

skcc75 · 2018-04-01T12:04:16Z

@jasnell #317 (comment)

jasnell · 2018-04-01T12:18:48Z

Ok, so it's still an open discussion then. Rather than committing to these names for the next number of years, I'd rather we just come up with a better scheme now.

shelleyp · 2018-04-01T13:12:54Z

As I noted elsewhere #291 lordie, what is the issue now?

Other than Axel's legitimate concern #317 (comment) (gold does have unique connotations) the list is toasty.

More importantly, you'll be done. Done. A not-that-consequential item will actually be resolved, and you can then move on to the what-will-we-ultimately-do-about-buffer-constructor issue.

Trott · 2018-04-01T15:14:19Z

Rather than committing to these names for the next number of years, I'd rather we just come up with a better scheme now.

@jasnell Those two options are not mutually exclusive. Sure, let's come up with a better naming scheme. But in the meantime, let's have a list of names that don't need to be debated until that new scheme comes. Approve this, and you still don't have to debate names for individual releases even if conversation about whether the theme should be Futurama characters or Simpsons characters drags on for 7 years.

Literally. You won't need a new theme until 2025. But if you manage to select a new theme before 10.x, then great. You can throw this out at that time.

Trott · 2018-04-01T15:18:48Z

@shelleyp By the way, I updated Gold to Gaiilium as suggested by @rauschma in #317.

jasnell · 2018-04-01T15:20:51Z

@Trott ... I'll look at this more tomorrow after the holiday. We're still 23 days out from the release so there's no reason to rush.

Trott · 2018-04-01T17:58:23Z

@Trott ... I'll look at this more tomorrow after the holiday. We're still 23 days out from the release so there's no reason to rush.

@jasnell Waiting a day is no big deal, and I'd rather get more @nodejs/release approvals anyway. But please let us not give even the appearance of slow-walking this.

We all complain (correctly) that it is impossible to keep track of everything that goes on across the nodejs project issue trackers. This is an opportunity to short-circuit predictable endless low-value bike-shedding. Failure to do this means needlessly exacerbating the very problem we presumably are interested in addressing.

styfle · 2018-04-01T18:38:12Z

I may have missed this part of the discussion, but are you intentionally skipping J?

That might confuse users who don’t know the complete list of code names.

drewfish · 2018-04-01T22:04:52Z

@styfle There are no chemical element names that start with J, not in English at least. (Or not yet... perhaps someone will discover/name something by 2023 😄)

styfle · 2018-04-01T22:07:24Z

@drewfish Yes I am aware of the issue.

But perhaps this PR should end at Iron and then we can bikeshed J at a future date. And it is possible something will be discovered in that time.

styfle · 2018-04-01T22:15:46Z

+* Gallium (16.x 2021)
+* Hydrogen (18.x 2022)
+* Iron (20.x 2023)
+* Krypton (22.x 2024)


Remove Krypton and Lithium.

styfle

Remove Krypton and Lithium. This is assuming we will skip J and I don't think this PR should be making that assumption.

Everything else looks good 👍

Trott · 2018-04-01T22:52:54Z

@styfle I agree on not assuming we'll skip J so I took out the K and L names. Now the list will get us out "only" 5 years to 2023.

Trott · 2018-04-01T23:11:28Z

Hmmm...unfortunately @nodejs/release does not in fact contain everyone listed in the README as a member. (In fact, it is less than half the people listed!) Despite what the README says to the contrary, it looks like the full membership (or at least something closer to it) is in @nodejs/LTS.

So, uh: @nodejs/LTS PTAL.

Trott · 2018-04-02T06:01:27Z

Hmmm...my attempt to @-mention @nodejs/lts failed. Preview tells me this one will succeed. So trying again...

@nodejs/lts PTAL

bnb · 2018-04-02T18:50:45Z

I am not a member of the Releases WG, but +1 from me. Thanks for taking the needed initiative here, @Trott ❤️

jasnell · 2018-04-02T19:52:19Z

+* Boron (6.x 2016)
+* Carbon (8.x 2017)
+* Dubnium (10.x 2018)
+* Erbium (12.x 2019)


Please mark everything for 12.x and higher as "tentative".

That is... tentative in so far as we may come up with a different naming scheme.

"Codenames for future releases are subject to change." This way we don't have to update this document every release.

gibfahn · 2018-04-03T13:06:37Z

+1 on this, let's just have a set of names we can default to, then if there's ever enough of an agreement to change the names then we can do that (be it next week or in 4 years).

FWIW I think the best text name for Node 10.x is Ten, but that's just me 😁 .

However I think if we're going to have this it should be machine readable, so we can use it for backporting.

ljharb · 2018-04-03T14:22:54Z

@gibfahn nvm reads it from the index.tab on nodejs.org/dist, is that not what you mean by machine readable?

gibfahn · 2018-04-03T15:39:19Z

@gibfahn nvm reads it from the index.tab on nodejs.org/dist, is that not what you mean by machine readable?

That's fine, but I'm talking about having a tool for backporting that works out that the first LTS version of Node 8 (8.6.0 or whatever) should be called Node Carbon for creating the release, so it can't rely on that page.

I'm fine with that format though.

srl295 · 2018-04-03T17:35:17Z

machine readable

Isn't the codename already a field in https://github.com/nodejs/Release/blob/master/schedule.json ? Could we just add values to that (marked tentative)?

mhdawson

LGTM

gibfahn · 2018-04-03T22:11:33Z

Isn't the codename already a field in /schedule.json@master ? Could we just add values to that (marked tentative)?

SGTM

Trott · 2018-04-05T21:16:27Z

Someone land this! (I'm not a member of the working group so I'm not going to do it because that would be rude.)

srl295

approved with a friendly amendment

srl295 · 2018-04-06T01:41:19Z

@@ -0,0 +1,12 @@
+This file contains a list of codenames for LTS releases. Codenames for future
+releases are subject to change.


It just hit me that this is the same repo as ./schedule.json. Could we at least mention that file or even have a link from there?

also README.md here mentions the codenames and could link to CODENAMES.md

srl295

approved with a friendlty amendment

srl295 · 2018-04-06T01:42:16Z

@@ -0,0 +1,12 @@
+This file contains a list of codenames for LTS releases. Codenames for future
+releases are subject to change.


also README.md here mentions the codenames and could link to CODENAMES.md

Trott · 2018-04-09T23:34:42Z

@srl295 Added the links you requested. Everyone else might want to review. Also: Someone please land this! 😄

PR-URL: nodejs#318 Fixes: nodejs#317

PR-URL: nodejs/Release#318 Fixes: nodejs/Release#317

add CODENAMES.md

b42ce88

Fixes: nodejs#317

cjihrig approved these changes Mar 31, 2018

View reviewed changes

Update CODENAMES.md

d448aaa

richardlau approved these changes Apr 1, 2018

View reviewed changes

Update CODENAMES.md

e888aeb

tunnckoCore mentioned this pull request Apr 1, 2018

Node.js 10.0.0 Tracking #291

Closed

jasnell reviewed Apr 1, 2018

View reviewed changes

Trott mentioned this pull request Apr 1, 2018

Pick the next ten codenames or something like that #317

Closed

styfle reviewed Apr 1, 2018

View reviewed changes

styfle approved these changes Apr 1, 2018 •

edited

Loading

View reviewed changes

styfle suggested changes Apr 1, 2018

View reviewed changes

Update CODENAMES.md

8e0e670

styfle approved these changes Apr 1, 2018

View reviewed changes

styfle mentioned this pull request Apr 1, 2018

Periodic Table does not have an element starting with "J" or "Q" or "W" #304

Open

jasnell reviewed Apr 2, 2018

View reviewed changes

mhdawson approved these changes Apr 3, 2018

View reviewed changes

squash

c045990

jasnell approved these changes Apr 5, 2018

View reviewed changes

rvagg approved these changes Apr 5, 2018

View reviewed changes

srl295 approved these changes Apr 6, 2018

View reviewed changes

Trott added 2 commits April 9, 2018 16:32

add link to schedule.json in CODENAMES.md

0912c3a

add link to CODENAMES.md from README.md

b9b2746

srl295 approved these changes Apr 10, 2018

View reviewed changes

gibfahn approved these changes Apr 10, 2018

View reviewed changes

gibfahn merged commit 7dd5235 into nodejs:master Apr 10, 2018

ChALkeR pushed a commit to ChALkeR/LTS that referenced this pull request Jun 30, 2018

add CODENAMES.md (nodejs#318)

df98659

PR-URL: nodejs#318 Fixes: nodejs#317

targos mentioned this pull request Dec 8, 2018

Proposal: Switching LTS Naming Scheme to Cities of the World #319

Closed

Trott deleted the codenames branch March 5, 2022 03:03

Soufiane88216 added a commit to Soufiane88216/Release that referenced this pull request Jan 30, 2025

add CODENAMES.md (#318)

fe8fd45

PR-URL: nodejs/Release#318 Fixes: nodejs/Release#317

		@@ -0,0 +1,12 @@
		This file contains a list of codenames for LTS releases. Codenames for future
		releases are subject to change.

Conversation

Trott commented Mar 31, 2018

Uh oh!

tunnckoCore commented Mar 31, 2018

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

skcc75 commented Apr 1, 2018

Uh oh!

jasnell commented Apr 1, 2018

Uh oh!

shelleyp commented Apr 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Apr 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Apr 1, 2018

Uh oh!

jasnell commented Apr 1, 2018

Uh oh!

Trott commented Apr 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

styfle commented Apr 1, 2018

Uh oh!

drewfish commented Apr 1, 2018

Uh oh!

styfle commented Apr 1, 2018

Uh oh!

styfle Apr 1, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

styfle left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Apr 1, 2018

Uh oh!

Trott commented Apr 1, 2018

Uh oh!

Trott commented Apr 2, 2018

Uh oh!

bnb commented Apr 2, 2018

Uh oh!

jasnell Apr 2, 2018

Choose a reason for hiding this comment

Uh oh!

jasnell Apr 2, 2018

Choose a reason for hiding this comment

Uh oh!

Trott Apr 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yvettep321 Mar 5, 2022

Choose a reason for hiding this comment

Uh oh!

gibfahn commented Apr 3, 2018

Uh oh!

ljharb commented Apr 3, 2018

Uh oh!

gibfahn commented Apr 3, 2018

Uh oh!

srl295 commented Apr 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

gibfahn commented Apr 3, 2018

Uh oh!

Trott commented Apr 5, 2018

Uh oh!

srl295 left a comment

Choose a reason for hiding this comment

shelleyp commented Apr 1, 2018 •

edited

Loading

Trott commented Apr 1, 2018 •

edited

Loading

Trott commented Apr 1, 2018 •

edited

Loading

Trott Apr 5, 2018 •

edited

Loading

srl295 commented Apr 3, 2018 •

edited

Loading

srl295 Apr 6, 2018 •

edited

Loading