Skip to content

land: add non-interactive mode - #366

Merged
priyank-p merged 1 commit into
nodejs:masterfrom
mmarchini:non-interactive-mode
Jan 3, 2020
Merged

priyank-p merged 1 commit into
nodejs:masterfrom
mmarchini:non-interactive-mode

Conversation

@mmarchini

Copy link
Copy Markdown
Contributor

Non-interactive mode will try to land a Pull Request without asking any
questions. This is meant to be used by scripts and CI landing tools.

Comment thread lib/landing_session.js Resolved
@codecov

codecov Bot commented Oct 1, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #366 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   75.52%   75.66%   +0.13%     
==========================================
  Files          21       21              
  Lines        1418     1422       +4     
==========================================
+ Hits         1071     1076       +5     
+ Misses        347      346       -1
Impacted Files Coverage Δ
lib/cli.js 89.83% <100%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1230b07...d669ecc. Read the comment docs.

@mmarchini

Copy link
Copy Markdown
Contributor Author

I'll try to add some tests.

Comment thread components/git/land.js Resolved
@mmarchini
mmarchini force-pushed the non-interactive-mode branch from d8fd92f to 63542c4 Compare October 10, 2019 15:28
@mmarchini

Copy link
Copy Markdown
Contributor Author

Changed to --yes with the behavior described in #366 (comment).

@mmarchini
mmarchini force-pushed the non-interactive-mode branch from 63542c4 to c709d08 Compare November 1, 2019 22:42
@mmarchini
mmarchini force-pushed the non-interactive-mode branch from c709d08 to 3e3fd17 Compare December 9, 2019 19:11

@targos targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmarchini
mmarchini force-pushed the non-interactive-mode branch from 3e3fd17 to 343865a Compare December 16, 2019 18:30
@mmarchini

Copy link
Copy Markdown
Contributor Author

@targos done!

Non-interactive mode will try to land a Pull Request without asking any
questions. This is meant to be used by scripts and CI landing tools.
@mmarchini
mmarchini force-pushed the non-interactive-mode branch from 343865a to d669ecc Compare January 2, 2020 19:54
@mmarchini

Copy link
Copy Markdown
Contributor Author

CI is passing 🎉

@targos do you mind landing this? I don't have commit access here.

@priyank-p
priyank-p merged commit 1538e21 into nodejs:master Jan 3, 2020
@priyank-p

Copy link
Copy Markdown
Contributor

@mmarchini merged!

@targos

targos commented Jan 6, 2020

Copy link
Copy Markdown
Member

released in 1.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants