Repository navigation
napi test throws error #13031
Description
- Version: v8.0.0-pre ( hash 9516aa1)
- Platform: MacOSX
- Subsystem: napi
make test
Throws following error on mac.
=== release test ===
Path: addons-napi/test_array/test
assert.js:557
throw actual;
^
TypeError: test_array.TestGetElement is not a function
at assert.throws (/Users/rgaunker/os/node/test/addons-napi/test_array/test.js:24:16)
at _tryBlock (assert.js:514:5)
at _throws (assert.js:535:12)
at Function.throws (assert.js:565:3)
at Object.<anonymous> (/Users/rgaunker/os/node/test/addons-napi/test_array/test.js:22:8)
at Module._compile (module.js:569:30)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:503:32)
at tryModuleLoad (module.js:466:12)
at Function.Module._load (module.js:458:3)
Command: out/Release/node --napi-modules /Users/rgaunker/os/node/test/addons-napi/test_array/test.js
[03:12|% 100|+ 1529|- 3]: Done
make: *** [test] Error 1
Activity
zimbabao commentedon May 15, 2017
Likely old napi build folder ./test/addons-napi/test_array/build/ is not cleaned or updated even after code is changed.
Trott commentedon May 15, 2017
My knowledge in this area is limited but: There's a
test-addons-cleantask in theMakefilethat I think is for when things get in a stale state. But it doesn't cleanaddons-napinor is there a separate task that does that.joyeecheung commentedon May 15, 2017
@Trott
test-addons-cleanwas added before napi lands so now it needs an update...I'll open a PR for that.Meanwhile, does adding rules like
test-addons-cleantomake cleansound like a good idea? There is alsotest-gc-cleanwhich cleans up artifacts generated bytest-gc(not run if you justmake clean, has to be triggered separately). In my experience it's pretty common to bump into stale addon builds when you are switching branches (e.g. when backporting)zimbabao commentedon May 15, 2017
make clean should clean should clean all or atleast should have target like reallyclean .
build: clean up napi build in test-addons-clean
build: clean up napi build in test-addons-clean
cjihrig commentedon Jul 6, 2017
@zimbabao is this still an issue?
zimbabao commentedon Jul 6, 2017
@cjihrig : Haven't faced issue anymore. Closing the ticket.