Skip to content

module: force require('process') to return a reference to process - #206

Closed
lxe wants to merge 1 commit into
nodejs:v0.12from
lxe:require-process
Closed

lxe wants to merge 1 commit into
nodejs:v0.12from
lxe:require-process

Conversation

@lxe

@lxe lxe commented Dec 23, 2014

Copy link
Copy Markdown

This makes require('process') always return a reference to the global process object. Fixes #157

@vkurchatkin

Copy link
Copy Markdown
Contributor

Why not module.exports = global.process?

@lxe

lxe commented Dec 23, 2014

Copy link
Copy Markdown
Author

@vkurchatkin there were a few ways to do this... making lib/process.js with module.exports = process is certainly one of them, and I wasn't sure which one would look more like a hack. We're already removing lib/sys which did the one-line re-export, so I was thinking we probably shouldn't create whole files just to do a re-export.

@bnoordhuis

Copy link
Copy Markdown
Member

I prefer the lib/process.js approach. Anything that doesn't require hacking lib/module.js.

@lxe

lxe commented Dec 23, 2014

Copy link
Copy Markdown
Author

@bnoordhuis added lib/process.js instead of the conditionals.

Comment thread lib/process.js Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to either // Copyright io.js contributors or your own / your company's name?

@bnoordhuis

ghost commented Dec 24, 2014

Copy link
Copy Markdown
Member

LGTM technically but as the discussion in #157 doesn't appear to have reached a conclusion, I won't merge it straight away. I'll bring it up at the next TC meeting unless enough TC members +1 it before that.

@lxe

ghost commented Dec 25, 2014

Copy link
Copy Markdown
Author

Happy holidays everyone!

@bnoordhuis

ghost commented Dec 30, 2014

Copy link
Copy Markdown
Member

@lxe Still one nit but if you fix that, I'll land it. Thanks.

This makes require('process') always return a reference to the global
process object.
@lxe

ghost commented Dec 30, 2014

Copy link
Copy Markdown
Author

@bnoordhuis totally missed that one! Thanks.

@bnoordhuis

ghost commented Dec 30, 2014

Copy link
Copy Markdown
Member

Cheers Aleksey, landed in d8586ea. I had to reword the first line to make it fit in 50 columns. Thanks!

@bnoordhuis bnoordhuis closed this Dec 30, 2014
@lxe

ghost commented Dec 30, 2014

Copy link
Copy Markdown
Author

Great stuff @bnoordhuis. thank you!

@rvagg

ghost commented Jan 2, 2015

Copy link
Copy Markdown
Member

ftr, agreed to merge this in TC meeting 2014-12-30 #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants