Skip to content

fs: allow position parameter to be a BigInt in read and readSync - #36190

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:fs/fix-position-validation-in-read
Closed

fs: allow position parameter to be a BigInt in read and readSync#36190
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:fs/fix-position-validation-in-read

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Nov 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #36185

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@aduh95 aduh95 aduh95 approved these changes
@jasnell jasnell jasnell approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@himself65 himself65 himself65 approved these changes
@BridgeAR BridgeAR Awaiting requested review from BridgeAR
+1 more reviewer
@rentalhost rentalhost rentalhost left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fs Issues and PRs related to file-system APIs and the fs module. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs.readSync & fs.read position argument does not support BigInt