Skip to content

fs: do not disable fd-based APIs in permission audit mode - #66726

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:do-not-disable-fd-based-apis-in-permission-audit-m
Open

fs: do not disable fd-based APIs in permission audit mode#66726
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:do-not-disable-fd-based-apis-in-permission-audit-m

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 14, 2026

Copy link
Copy Markdown
Member

fs: do not disable fd-based APIs in permission audit mode

@RafaelGSS
fs: do not disable fd-based APIs in permission audit mode
33ae003 
Refs: nodejs#65659
Refs: nodejs#65419
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.48%. Comparing base (dd7235c) to head (33ae003).
⚠️ Report is 363 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/fs/promises.js 28.57% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #66726      +/-   ##
==========================================
- Coverage   90.48%   90.48%   -0.01%     
==========================================
  Files         791      791              
  Lines      277204   277208       +4     
  Branches    53311    53314       +3     
==========================================
+ Hits       250841   250843       +2     
- Misses      16760    16788      +28     
+ Partials     9603     9577      -26
Files with missing lines Coverage Δ
lib/fs.js 97.32% <100.00%> (+<0.01%) ⬆️
lib/internal/fs/promises.js 91.14% <28.57%> (+<0.01%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model. label Oct 31, 2026
@RafaelGSS

RafaelGSS commented Oct 31, 2026

Copy link
Copy Markdown
Member Author

ping @nodejs/security-wg

@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 9, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 9, 2026
@nodejs-github-bot

nodejs-github-bot commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78940/

@sxa sxa mentioned this pull request Nov 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RafaelGSS @nodejs-github-bot @UlisesGascon