Skip to content

deps: restore LoongArch64 build fix for brotli - #67080

Open
Javonne-liu wants to merge 1 commit into
nodejs:mainfrom
Javonne-liu:deps-brotli-loongarch64-model
Open

Javonne-liu wants to merge 1 commit into
nodejs:mainfrom
Javonne-liu:deps-brotli-loongarch64-model

Conversation

@Javonne-liu

Copy link
Copy Markdown
Contributor

This PR restores the LoongArch64 build fix for Brotli that was accidentally dropped during the Brotli 1.2.1 update in commit 578d081.

The original fix was previously merged in #61003. Since the upstream Brotli commit (e230f474b87) is not included in their v1.2.1 release tag, this floating patch needs to be reapplied.

Currently, the LoongArch64 CI is in a failed state. After upgrading Brotli to 1.2.1, the LoongArch64 architecture compilation fails with the invalid argument of ‘model’ attribute error:

13:05:41 ../deps/brotli/c/enc/command.h:29:10: error: invalid argument of 'model' attribute
13:05:41    29 | uint32_t kBrotliCopyExtra[BROTLI_NUM_INS_COPY_CODES];
13:05:41       |          ^~~~~~~~~~~~~~~~
13:05:41 make[2]: *** [deps/brotli/brotli.target.mk:122: /home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/obj.target/brotli/deps/brotli/c/enc/backward_references.o] Error 1
13:05:41 rm a5d0e6f67c554c4fa665a61975501fed77bc952757b2bceafbe124a7fdcdabfb.intermediate d571371d92e3d0ff2d2dce6435600821af263424289ef48009606332900e1870.intermediate
13:05:41 make[1]: *** [Makefile:145: node] Error 2
13:05:41 make: *** [Makefile:675: build-ci] Error 2

Origin commit message:

disable BROTLI_MODEL macro for some targets

PiperOrigin-RevId: 827486322

Refs: google/brotli@e230f47

Origin commit message:

    disable BROTLI_MODEL macro for some targets

    PiperOrigin-RevId: 827486322

Refs: google/brotli@e230f47
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added brotli Issues and PRs related to the Brotli dependency. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

brotli Issues and PRs related to the Brotli dependency. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants