Skip to content

meta: skip lighthouse CI when no vercel preview detected - #7266

Merged
bmuenzenmeyer merged 1 commit into
mainfrom
chore/redyetidev/lighthouse-skip
Nov 27, 2024
Merged

bmuenzenmeyer merged 1 commit into
mainfrom
chore/redyetidev/lighthouse-skip

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Description

This changes the Lighthouse CI to skip when a Vercel preview is not detected

Related Issues

#7253

Signed-off-by: Aviv Keller <redyetidev@gmail.com>
@avivkeller
avivkeller requested a review from Copilot November 20, 2024 21:28
@avivkeller
avivkeller requested a review from a team as a code owner November 20, 2024 21:28
@vercel

vercel Bot commented Nov 20, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:28pm

@avivkeller

Copy link
Copy Markdown
Member Author

The commit message didn't save 🤔, regardless, the PR title will be used, right? If not, feel free to force push and fix it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@avivkeller

Copy link
Copy Markdown
Member Author

image
Without a Vercel preview, the Lighthouse CI is skipped, as shown above.

Comment thread .github/workflows/lighthouse.yml Resolved
Comment thread .github/workflows/lighthouse.yml Resolved
Comment thread .github/workflows/lighthouse.yml Resolved
@github-actions

github-actions Bot commented Nov 23, 2024 •

Copy link
Copy Markdown
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.611s ⏱️

@bmuenzenmeyer
bmuenzenmeyer added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 9202c36 Nov 27, 2024
@bmuenzenmeyer
bmuenzenmeyer deleted the chore/redyetidev/lighthouse-skip branch November 27, 2024 12:40
@avivkeller

Copy link
Copy Markdown
Member Author

👋 follow-up #7361

This branch was successfully deployed

2 active deployments
Storybook — 5c8c29ad Deployed Nov 23, 2024 by ovflowd
Preview — 5c8c29ad Deployed Nov 20, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants