Skip to content

Organise member translation for spatial types #1004

Description

@YohDeadfall

Why do you use literals instead of nameofs? Is it EF style?

Not at all - it was just this way before and I didn't notice. Changed to nameof.

This exposed that the translation tables aren't well-organized, especially in the member translator - some properties specific to a certain type of geometry are in the general switch. However, this needs to be studied a bit closer, as some properties exist on several geometry types, etc. Unfortunately I don't have time to dive into this at the moment, let's merge as-is and deal with problems as they come up - this has been working for a while without reported issues.

Originally posted by @roji in https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/pull/1000/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions