Repository navigation
chore: migrate Cygwin installer - #10241
Merged
Merged
Conversation
Use the installer root output for verification, diagnostics, and Windows shim tests without changing PATH. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d1d25a0b-19b1-4d62-88b0-f7ba9788adde
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
egor-tensin/setup-cygwinwithcygwin/cygwin-install-action@v7, keeping PATH modification disabled and the installer's default integrity checks enabled.Use the action's
rootoutput for the Bash probe, installer diagnostics, and Windows shim tests instead of assumingC:\cygwin64. Missing roots and nonzero Bash exits fail explicitly; mandatory CI coverage cannot silently skip missing Cygwin configuration. Failure diagnostics handle missing outputs and literal log paths containing spaces or brackets. Existing shell coverage and Cygwin cwd-related skips are unchanged.This is a migration-only PR targeting
latest, separate from #10234. Cygwin changes have been removed from that integration PR, leaving the two PRs with disjoint file scopes.Refs #10025 and #10027.
Validation
Root lint, template consistency, existing shim tests on macOS, and whitespace checks pass. Windows-specific shell cases skip on macOS. Twenty-four session-local checks pass across all three release lines, including Windows path selection, missing-root mandatory failure, actual PowerShell probe exit handling, and literal-path diagnostic log tails.
Actual Windows installation and full shim execution still require PR CI. No release workflow was dispatched.