Repository navigation
deps: read-cmd-shim@7.0.1 - #10254
Merged
Merged
Conversation
Recognize shell shims emitted by the bundled cmd-shim version. Fixes #10140. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e7ffecd2-07aa-4a72-b7ed-9753289633e0
nkolev92
approved these changes
Nov 9, 2026
jeffkl
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the bundled
read-cmd-shimfrom 7.0.0 to 7.0.1 and synchronize its lockfile version, tarball URL, and integrity.The bundled
cmd-shim@9.0.2generates shell shim targets using$basedir_win, but the 7.0.0 reader only recognizes$basedir. This causes existing valid shims to be rejected withENOTASHIM, surfaced by bin-links asEEXISTduring ownership checks or recreation.The published 7.0.1 reader accepts both shell path formats. Its bundle was extracted from the registry tarball with integrity verification; no cmd-shim or bin-links source changes are included.
Fixes #10140.
Refs npm/read-cmd-shim#137 and npm/bin-links#197.
The existing bin-links range already permits this patch, so this bundle update does not require waiting for a bin-links release. The companion bin-links PR raises its reader minimum and adds a regression test.
Validation
node . run test --ignore-scripts -- test/lib/commands/install.js --no-coveragepasses.node . run lint --ignore-scriptsandgit diff --checkpass.Validated on Linux with Node 24.15.0. Targeted coverage-disabled testing is not a full package/coverage run, and the native Windows/macOS/Node CI matrix was not run locally.