Skip to content

deps: read-cmd-shim@7.0.1 - #10254

Merged
martinrrm merged 1 commit into
latestfrom
fix/read-cmd-shim-7.0.1
Nov 10, 2026
Merged

martinrrm merged 1 commit into
latestfrom
fix/read-cmd-shim-7.0.1

Conversation

@martinrrm

Copy link
Copy Markdown
Contributor

Summary

Update the bundled read-cmd-shim from 7.0.0 to 7.0.1 and synchronize its lockfile version, tarball URL, and integrity.

The bundled cmd-shim@9.0.2 generates shell shim targets using $basedir_win, but the 7.0.0 reader only recognizes $basedir. This causes existing valid shims to be rejected with ENOTASHIM, surfaced by bin-links as EEXIST during ownership checks or recreation.

The published 7.0.1 reader accepts both shell path formats. Its bundle was extracted from the registry tarball with integrity verification; no cmd-shim or bin-links source changes are included.

Fixes #10140.
Refs npm/read-cmd-shim#137 and npm/bin-links#197.

The existing bin-links range already permits this patch, so this bundle update does not require waiting for a bin-links release. The companion bin-links PR raises its reader minimum and adds a regression test.

Validation

  • node . run test --ignore-scripts -- test/lib/commands/install.js --no-coverage passes.
  • node . run lint --ignore-scripts and git diff --check pass.
  • A direct integration check against the actual bundled dependencies passes 14 assertions covering sync/async reads of shell, CMD, and PowerShell shims; current and legacy shell formats; global ownership and prefix-collision checks; rejection of unrelated files; and shim recreation without force.
  • Bundled version and lockfile version/integrity agree.

Validated on Linux with Node 24.15.0. Targeted coverage-disabled testing is not a full package/coverage run, and the native Windows/macOS/Node CI matrix was not run locally.

Recognize shell shims emitted by the bundled cmd-shim version.

Fixes #10140.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e7ffecd2-07aa-4a72-b7ed-9753289633e0
@martinrrm
martinrrm merged commit d538936 into latest Nov 10, 2026
26 checks passed
@martinrrm
martinrrm deleted the fix/read-cmd-shim-7.0.1 branch November 10, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Windows: EEXIST on bin shims that npm wrote itself (bundled read-cmd-shim 7.0.0 cannot read the $basedir_win shims of cmd-shim 9.0.2)

3 participants