Repository navigation
Upgrade standalone Spring Core metadata readers for Java 25 - #1409
Draft
jkschneider wants to merge 3 commits into
Draft
jkschneider wants to merge 3 commits into
jkschneider wants to merge 3 commits into
Conversation
timtebeek
marked this pull request as draft
November 3, 2026 12:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vaadin's Maven plugin compiles after Java 25 migration, but its metadata-reader tests fail because Spring Core 5.3.19's shaded ASM rejects class-file version 69.
Add an explicitly bounded Spring Core 5.3 OSS → 6.2.11 major upgrade for standalone Maven metadata readers. Require a resolved Core/JCL-only Spring graph and typed usage confined to supported implementation APIs. Refuse Spring Framework/Boot management, other Spring families, unknown parents/BOMs, mixed versions, unsupported source kinds, exposed Spring signatures, fields and unrecognized APIs. Change declaration-local versions while preserving shared properties, and refresh the Maven dependency model.
Validation: 50 actual-source tests pass independently with production compiled for Java 8 and tests on Java 25. Independent review includes generic API exposure, records, profile management and model-refresh controls. The actual resolved consumer graph contains only Spring Core/JCL 5.3.19. Running the same compiled three metadata-reader tests with Core/JCL 5.3.19 fails; substituting 6.2.11 passes all three. Full recipe replay on the original four-repository Maven scope now confirms Vaadin compiles on Java 25 and its three metadata-reader tests pass. The six-test check retains exactly three original Plexus NoSuchMethodError failures, so it is not a fully passing consumer check. Native CI passes.