Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
isfollowed by an uppercase letter.UseLombokSetterandAdoptLombokSetterMethodNames.What's your motivation?
For a primitive boolean field named
isFoo, Lombok generatessetFoo().The recipes previously expected
setIsFoo(), which could remove or rename the wrong method and break existing callers.Refs #1330 (F2)
Anything in particular you'd like reviewers to focus on?
Please confirm that handling the primitive boolean
isFoocase in the shared setter-name helper is the preferred approach.Checklist