Repository navigation
ci: pin third-party GitHub Actions to commit SHAs - #892
Merged
Merged
Conversation
A tag can be moved by the action's author, or by anyone who takes over their account, and the workflow then runs that code with the repository's permissions. release.yml publishes to PyPI, so it matters most there. Each SHA is the commit that the tag pointed to when this was written, found with the GitHub API (following an annotated tag to its commit), and the version is in a comment. pypa/gh-action-pypi-publish was on the moving branch release/v1 and is now on v1.14.3, which is its head. Dependabot's github-actions ecosystem is already enabled and updates a pinned SHA together with its version comment. GitHub's own actions/* stay on tags. See petercorke/rvc-ecosystem#24. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
enabled auto-merge (squash)
October 22, 2026 23:50
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 16684 16684
=====================================
Misses 16684 16684 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
10 tasks
petercorke
added a commit
to petercorke/pgraph-python
that referenced
this pull request
Oct 31, 2026
- Delete posegraph.py, a 2020 prototype in the repository root that nothing
uses: it imports the deprecated UVertex, has a stub method and debug prints,
and needs itertools.pairwise (Python 3.10) in a package that supports 3.9.
The Robotics Toolbox has the real PoseGraph.
- examples/create_json.py: pop('dgoal', None) instead of a bare except.
- Pin the two remaining third-party GitHub Actions to commit SHAs with the
version in a comment, as RTB did in petercorke/robotics-toolbox-python#892:
codecov/codecov-action v7.1.1 and dependabot/fetch-metadata v3.1.0. They are
the commits that @v7 and @V3 point to today, so what runs is unchanged.
GitHub's own actions/* stay on tags, and Dependabot updates a pinned SHA with
its comment.
- Ignore build/ as well as docs/build and dist/.
Part of #23.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins the six third-party GitHub Actions used in RTB's workflows to full commit SHAs, with the version in a comment. Seven references in five files. This is the RTB pilot of petercorke/rvc-ecosystem#24, which has the reasoning and the survey of the other repos.
A tag such as
@v6can be moved by the action's author, or by anyone who takes over their account, and the workflow then runs that code with the repository's permissions.release.ymlpublishes to PyPI, so it matters most there. Codacy reports it (7 findings).amannn/action-semantic-pull-request@v648f2562…v6.1.1codecov/codecov-action@v7303a32d…v7.1.1dependabot/fetch-metadata@v325dd0e3…v3.1.0googleapis/release-please-action@v545996ed…v5.0.0pypa/cibuildwheel@v4.2.1e090b81…v4.2.1pypa/gh-action-pypi-publish(twice)@release/v1(a moving branch)7245906…v1.14.3Same code as before
Each SHA is the commit that its tag, or for the PyPI action the branch head, points to today. I found each with the GitHub API, following an annotated tag to its commit, and checked that a version tag points at that same commit. So the code that runs is unchanged.
Upkeep
Dependabot's
github-actionsecosystem is already enabled for this repo, and it updates a pinned SHA together with its version comment. GitHub's ownactions/*stay on tags.Not tested
release.ymlandrelease-rtb-data.ymlcannot be run without a release, so the SHAs there are verified by the API check above and not by running them.ci.yml(codecov) and the PR title check (amannn) run on this PR.🤖 Generated with Claude Code