Skip to content

ci: remove obsolete Cloud ZH TOC sync - #24699

Merged
ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
lilin90:scope-ai-workflow-secrets
Nov 17, 2026
Merged

ti-chi-bot[bot] merged 5 commits into
pingcap:masterfrom
lilin90:scope-ai-workflow-secrets

Conversation

@lilin90

@lilin90 lilin90 commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

What is changed, added, or deleted? (Required)

Remove the obsolete Cloud ZH TOC sync workflow.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review
Walkthrough

Several GitHub Actions workflows now use the pinned shared authorization workflow to gate privileged jobs. The workflow test now expects link.yaml to use the local authorization workflow and the other listed workflows to use the pinned shared workflow.

Changes: Privileged workflow authorization

Layer / File(s) Summary
Authorization gates and test
.github/workflows/doc_review.yml, .github/workflows/sync-cloud-zh-toc.yml, .github/workflows/sync-doc-pr-zh-to-en.yml, .github/workflows/translation-cron.yml, .github/workflows/translation-zh.yaml, scripts/test-privileged-workflow-actors.py
Four workflows add authorization jobs and gate their work on the authorization output matching the current run attempt. A fifth workflow switches to the pinned shared authorization workflow. The test checks the expected local or pinned workflow reference.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • pingcap/docs#24696: Adds authorization gates to translation and Chinese-to-English sync workflows, which this PR also changes.
  • pingcap/docs#24688: Changes the Cloud TOC sync workflow’s run and checkout behavior, which relates to the workflow changed here.

Suggested reviewers: shhdgit

Merge Risk: High · up to e96f3

The change does not yet bind the AI review, translation and TOC sync jobs to the new environments. Once repository-level secrets are removed as planned, these jobs would run without their credentials and fail. Add the environment bindings before merging or cutting over secrets.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title "ci: remove obsolete Cloud ZH TOC sync" matches the PR description, which states it removes the obsolete Cloud ZH TOC sync workflow. It is short, specific, and identifies the primary change.…
Description check Passed The description follows the repository template. It includes the change summary (removing the obsolete Cloud ZH TOC sync workflow), the affected version (master only), the related reference link, the …
Full details: Title check

Explanation

The title "ci: remove obsolete Cloud ZH TOC sync" matches the PR description, which states it removes the obsolete Cloud ZH TOC sync workflow. It is short, specific, and identifies the primary change. The raw summary describes edits to authorization and allowlist conditions across several workflows, which the title does not mention. That gap is an aspect of the title, not a mismatch.

Full details: Description check

Explanation

The description follows the repository template. It includes the change summary (removing the obsolete Cloud ZH TOC sync workflow), the affected version (master only), the related reference link, the AI agent involvement section, and the delete-files checkbox. The first-time contributor checklist is omitted, which is acceptable because it is optional for the author. The description does not explain why the workflow is obsolete. It also does not mention the authorization and allowlist changes described in the raw summary, which the PR objectives reference.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2026
@lilin90 lilin90 self-assigned this Nov 16, 2026
@lilin90 lilin90 added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Nov 16, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Nov 16, 2026
@lilin90 lilin90 added the ONCALL Relates to documentation oncall. label Nov 16, 2026
@lilin90
lilin90 marked this pull request as ready for review November 16, 2026 09:08
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2026
@lilin90
lilin90 requested review from qiancai and a balanced review from Copilot November 16, 2026 09:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The security boundary depends on settings outside the diff, requiring maintainer verification of master-only/no-tag policies, secret migration and revocation, unattended scheduled runs, and rejection of disallowed refs.

No open issues 🎉

What changed in this PR

This PR binds credential-consuming AI workflows to dedicated GitHub Actions environments, enabling environment-level secret restrictions while preserving existing triggers, authorization checks, and translation branches.

Changes:

  • Adds environment bindings for AI review, translation, and Cloud TOC synchronization jobs.
  • Adds regression checks for the bindings and verifies authorization jobs remain outside credential environments.
  • Documents the required environment setup and credential migration before merging; these settings are not provisioned by the code changes.
File Description
scripts/​test-privileged-workflow-actors.py Tests credential environment bindings and authorization-job separation.
.github/​workflows/​translation-zh.yaml Binds Chinese translation to ai-doc-translation.
.github/​workflows/​translation-cron.yml Binds scheduled Japanese translation to ai-doc-translation.
.github/​workflows/​sync-doc-pr-zh-to-en.yml Binds Chinese-to-English synchronization to ai-doc-translation.
.github/​workflows/​sync-cloud-zh-toc.yml Binds Cloud TOC synchronization to cloud-toc-sync.
.github/​workflows/​doc_review.yml Binds AI documentation review to ai-doc-review.

Review effort: Balanced

@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2026
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2026
@lilin90 lilin90 changed the title ci: scope AI workflow secrets to environments ci: pin privileged workflow authorization Nov 17, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to GitHub limitations.

⚠️ Outside diff range comments (1)

Major · Bind sync-docs to the migrated translation environment. · sync-doc-pr-zh-to-en.yml:31

.github/workflows/sync-doc-pr-zh-to-en.yml:31
Major · Functional Correctness · Quick win

Bind sync-docs to the migrated translation environment.

This job also consumes AZURE_OPENAI_KEY and AZURE_OPENAI_BASE_URL, but has no environment binding. Removing their repository and organization copies also removes this job's credential access. Add environment: ai-doc-translation to sync-docs before the shared credential cutover. (raw.githubusercontent.com)

Review info

Run configuration

  • Source mode: Auto
  • Repository: pingcap/docs
  • Branch: master
  • File: .coderabbit.yaml
  • Commit: 11cf673
  • Layers: Repository YAML
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 723fbcc4-4961-49ee-bc26-6c22a3c0d9f6
Commits

Reviewing files that changed from the base of the PR and between d9c5c1b and e96f336.

Files selected for processing: 6

  • .github/workflows/doc_review.yml
  • .github/workflows/sync-cloud-zh-toc.yml
  • .github/workflows/sync-doc-pr-zh-to-en.yml
  • .github/workflows/translation-cron.yml
  • .github/workflows/translation-zh.yaml
  • scripts/test-privileged-workflow-actors.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread .github/workflows/doc_review.yml Resolved
Comment thread .github/workflows/sync-cloud-zh-toc.yml Resolved
Comment thread .github/workflows/translation-cron.yml Resolved
Comment thread .github/workflows/translation-zh.yaml Resolved
@lilin90 lilin90 changed the title ci: pin privileged workflow authorization ci: pin workflow authorization and remove obsolete TOC sync Nov 17, 2026
@lilin90 lilin90 changed the title ci: pin workflow authorization and remove obsolete TOC sync ci: remove obsolete Cloud ZH TOC sync Nov 17, 2026
@lilin90 lilin90 added the lgtm label Nov 17, 2026

@lilin90 lilin90 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot

ti-chi-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Nov 17, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit db26e52 into pingcap:master Nov 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ONCALL Relates to documentation oncall. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants