Repository navigation
ci: complete maintenance workflow authorization - #24696
ti-chi-bot[bot] merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain in the privileged-workflow authorization changes.
No open issues 🎉
What changed in this PR
This PR adds shared authorization checks to privileged maintenance workflows in pingcap/docs, covering link checks and Chinese-to-English PR synchronization.
Changes:
- Validate the repository,
masterbranch, allowed account IDs, current permissions, and rerun initiators while preserving initial scheduled runs. - Require authorization for the current run attempt and restrict keyword checks to upstream
master. - Add authorization regression tests to existing CI.
| File | Description |
|---|---|
scripts/test-privileged-workflow-actors.py |
Adds regression tests for authorization and workflow gates. |
.github/workflows/sync-doc-pr-zh-to-en.yml |
Requires current-attempt authorization before PR synchronization. |
.github/workflows/link.yaml |
Requires current-attempt authorization before link checks. |
.github/workflows/keywords.yaml |
Restricts keyword checks to upstream master. |
.github/workflows/ci.yaml |
Runs the new authorization regression tests. |
.github/workflows/authorize-privileged-workflow.yml |
Defines the reusable authorization gate. |
Review effort: Balanced
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is changed, added, or deleted? (Required)
Require authorization before maintenance workflows can scan links, create link-report issues, or use translation credentials.
docs-cn, adjusted forpingcap/docs. It checks the repository andmasterbranch, verifies the existing three allowed accounts by immutable account ID and current write/maintain/admin permission, and validates rerun initiators. Initial scheduled runs remain supported.masterin addition to its existing repository check.The English repository has no
flush-version.yaml; its corresponding PR synchronization workflow issync-doc-pr-zh-to-en.yml.Validation: authorization, media, doc-review, and safer-default regression scripts passed;
actionlint -shellcheck=passed for all changed workflows;git diff --checkpassed. No production workflows were manually dispatched and no production secrets were used.Scope: these guards restrict execution of the reviewed workflows. They do not isolate repository-level secrets from branch writers who can edit workflow definitions; separate repository/environment secret controls are required for that threat model.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit
masterbranch.