Repository navigation
Incorrect differences being generated with eslintv9 #697
Description
Hello
I originally raised this issue over on eslint : eslint/eslint#19258 so there's quite a bit of context there, however I've been debugging and the issue appears to be in the generateDifferences function of the eslint-plugin-prettier package.
It's a bit crude this debugging but on eslint-plugin-prettier.js, lines 243, I added:
if (source !== prettierSource) {
const differences = generateDifferences(source, prettierSource);
if(onDiskFilepath === '/Users/karl.stoney/git/autotrader/node-at-webserver/examples/basic-app/types/client/sdk.gen.ts') {
console.log(source)
console.log('--------------->')
console.log(prettierSource)
console.log('--------------->')
console.log(differences)
}
for (const difference of differences) {
reportDifference(context, difference);
}
}
If you notice the output in my terminal both source and prettierSource are correct, but the differences generated by generateDifferences includes
{ offset: 622, operation: 'delete', deleteText: '}' }
Which is incorrect.
Activity
Stono commentedon Dec 20, 2024
hmmm actually no this may be fine because you're inserting { on the difference above it.... gah
So it's back to being an eslint issue I think.
Stono commentedon Dec 20, 2024
Decided to reopen this because I'm not sure if the issue is with prettier, or eslint, but it only manifests since eslint v9.
https://github.com/Stono/eslint-19258 contains a reproduction
JounQin commentedon Jan 15, 2025
Should report to https://github.com/prettier/prettier-linter-helpers instead.
cc @BPScott
See the last two reports, they can not be applied one by one.
fisker commentedon Mar 6, 2025
I haven't looked deep, but I highly doubt this is not related to
prettier-linter-helpers, should be another conflicting rule.JounQin commentedon Mar 6, 2025
Nope. :(
fisker commentedon Mar 6, 2025
Right, prettier/prettier-linter-helpers#111 (comment)
fisker commentedon Mar 6, 2025
No, not related to
prettier-linter-helpers, the diff is correct. It's conflicting withno-trailing-spaces. But in a strange way.JounQin commentedon Mar 6, 2025
Yep.
fisker commentedon Mar 6, 2025
I'll report to ESLint.
fisker commentedon Mar 6, 2025
eslint/eslint#19258 (comment)