Repository navigation
Tooltip is incompatible with callback refs #8378
Description
Description
When I encountered #8373 I moved my callback ref to the wrapping Tooltip . This appeared to forward the ref to the underlying element as I wanted. However, if the passed ref is a callback ref, the tooltip never appears. This is not the case for an object ref.
Steps to reproduce
This breaks, even though it typechecks just fine. The log does get called, but the tooltip does not appear:
const logRef = useCallback(element => console.log(element), [])
return <Tooltip ref={logRef} text="Example"><Button>Button text</Button></Tooltip>This works, but isn't a callback ref:
const logRef = useRef(null)
return <Tooltip ref={logRef} text="Example"><Button>Button text</Button></Tooltip>And this shows the tooltip but never calls the log (#8373):
const logRef = useCallback(element => console.log(element), [])
return <Tooltip text="Example"><Button ref={logRef}>Button text</Button></Tooltip>Version
v38.37.0
Browser
No response
Activity
llastflowers commentedon Sep 8, 2026
This is fixed in #7644 and the changes are behind this feature flag: https://devportal.githubapp.com/feature-flags/primer_react_merged_forwarded_refs/overview
In this particular case, the feature flag hadn't yet been included in the tests' mocked feature flags, so the old (pre-#7644) behavior was present. Once enabled, this issue was cleared.
Slack convo for reference: https://github.slack.com/archives/C01L618AEP9/p1788372519672739
Leaving this issue open for now so we can decide if we should consider graduating this feature flag now or soon so issues like this don't pop up anymore. It seems like there have been no issues since the rollout.
guidari commentedon Sep 29, 2026
Is this issue open for contribution? 👀