Repository navigation
Fall back to LEFT/BASELINE for invalid textAlign() values - #9378
Open
harshiltewari2004 wants to merge 1 commit into
Open
harshiltewari2004 wants to merge 1 commit into
harshiltewari2004 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9356
Changes
textAlign()now replaces unknown horizontal values withLEFTand unknown vertical values withBASELINEbefore saving them (src/type/textCore.js).default:fallback to the 2D_positionLinesswitch to match WEBGL (src/core/p5.Renderer2D.js).textAlignunit tests intest/unit/type/attributes.js.Why the fix is in
textAlign()and not only in the 2D switchWhile checking vertical alignment (as suggested in the issue), I found that the 2D canvas ignores invalid values and keeps the previous one:
textAlign(LEFT, TOP)thentextAlign(LEFT, LEFT)textAlign(RIGHT)thentextAlign(TOP)textAlignstillrightSo a
default:alone would have drawn right-aligned text in the second case. Replacing bad values intextAlign()keeps p5's state, the canvas, and both renderers in sync. Thedefault:stays as a safety net.FES already warns for invalid values in both renderers, so that part is unchanged.
Tests
The two fallback tests fail on
mainand pass with this change.