Repository navigation
Remove contradictory state labels from snapshot metrics - #1256
Open
wangyusheng1985 wants to merge 1 commit into
Open
wangyusheng1985 wants to merge 1 commit into
wangyusheng1985 wants to merge 1 commit into
Conversation
Last-snapshot numeric metrics no longer carry a state label, which incorrectly put state="SUCCESS" on failed-shard series. State is now exposed as elasticsearch_snapshot_stats_snapshot_state. Fixes prometheus-community#786 Signed-off-by: yusheng.wang <yusheng.wang@chaitin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #786
Last-snapshot numeric metrics used
{repository,state,version}for every series, soelasticsearch_snapshot_stats_snapshot_failed_shardscould be labeledstate="SUCCESS".{repository}only{repository,version}elasticsearch_snapshot_stats_snapshot_state{repository,state,version} 1This is a breaking label change for the last-snapshot series.