Skip to content

Context manager for ConnectionPool#connection method #34

Closed

Description

@Veritaris

ATM to use connection we need to write the following code:

connection_pool = psqlpy.ConnectionPool()
conn = await connection_pool.connection()
conn.execute("SELECT * from users")

But it would be more pythonic to use context manager here like:

connection_pool = psqlpy.ConnectionPool()
async with connection_pool.connection() as conn:
    conn.execute("SELECT * from users")

Activity

  1. chandr-andr commented on Apr 17, 2024

    @chandr-andr
    Member

    Hi!
    Thank you for the issue.

    This idea is great, but It has some cons.

    We have an asynchronous connection() method because we need to make an asynchronous call to the database pool.
    When we get a connection that can be used in a context manager, it must have some magical method and access to the ConnectionPool.
    If we want to have 2 ways of connection declaration, we need to be available to start it explicitly, like Transaction has a begin method.
    Example:

    # First without context manager
    ...
    conn = connection_pool.connection()
    await conn.start()
    
    # Second with a context manager
    ...
    async with connection_pool.connection() as conn:

    It seems a bit complicated to me with some start method for connection.
    If you have another opinion please share it.

  2. chandr-andr commented on May 4, 2024

    @chandr-andr
    Member

    I've started implementing this, but I'm faced with performance issues.
    #36

    So, it will take time to understand how to do it in another way.

  3. chandr-andr commented on Jul 3, 2024

    @chandr-andr
    Member

    It's implemented in release https://github.com/qaspen-python/psqlpy/releases/tag/0.7.0 with the acquire method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions