You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe just start changing the style bit by bit where needed and allow for configuration to be passed in? That way over time the (total) style can be configured using a configuration file.
I should probably not comment on this as I'm not really familiar with cst and cst-simple.
@jvliwanag do you think that formatting is going bring a lot of complexity to these libs? If that is the case then from my perspective purty is the way to go (this trivial approach works fine in the case of mui bindings).
Passing the generated code over to purty is indeed tempting. But when using a codegen lib, I'd prefer not to have to pull in an additional dependency.
@flip111 I'm going with hat approach thanks. I'll submit a pull req onto this lib that changes the way it formats for now. Then I can work on making it configurable.
Activity
flip111 commentedon Nov 27, 2020
Maybe just start changing the style bit by bit where needed and allow for configuration to be passed in? That way over time the (total) style can be configured using a configuration file.
paluh commentedon Nov 29, 2020
I should probably not comment on this as I'm not really familiar with cst and cst-simple.
@jvliwanag do you think that formatting is going bring a lot of complexity to these libs? If that is the case then from my perspective purty is the way to go (this trivial approach works fine in the case of mui bindings).
jvliwanag commentedon Dec 9, 2020
@paluh comments of course helpful. :)
Passing the generated code over to purty is indeed tempting. But when using a codegen lib, I'd prefer not to have to pull in an additional dependency.
@flip111 I'm going with hat approach thanks. I'll submit a pull req onto this lib that changes the way it formats for now. Then I can work on making it configurable.