Skip to content

Additional fields required for bump-version command break local package reference. #459

Closed

Description

@nsaunders

I am using Spago v0.10.0.0.

The bump-version command can now generate a bower.json file, which is awesome. This feature requires some new fields in spago.dhall, namely license and repository.

Unfortunately, the additional fields break local package references:

spago: 
Error: Expression doesn't match annotation

- List …
+ { … : … }

 1│ { name =
 2│     "nodetrout"
 3│ , license =
 4│     "MIT"
 5│ , repository =
 6│     "https://github.com/nsaunders/purescript-nodetrout.git"
 7│ , dependencies =
 8│     [ "argonaut"
 9│     , "console"
10│     , "effect"
11│     , "form-urlencoded"
12│     , "http-methods"
13│     , "node-http"
14│     , "profunctor-lenses"
15│     , "psci-support"
16│     , "spec"
17│     , "trout"
18│     ]
19│ , packages =
20│     ./packages.dhall
21│ , sources =
22│     [ "src/**/*.purs", "test/**/*.purs" ]
23│ } : List Text

(input):1:1

The above error appears when I run spago build in the client/dependent project, where packages.dhall looks like this:

let mkPackage =
      https://raw.githubusercontent.com/purescript/package-sets/psc-0.13.3-20191005/src/mkPackage.dhall sha256:0b197efa1d397ace6eb46b243ff2d73a3da5638d8d0ac8473e8e4a8fc528cf57

let upstream =
      https://github.com/purescript/package-sets/releases/download/psc-0.13.3-20191005/packages.dhall sha256:ba287d858ada09c4164792ad4e643013b742c208cbedf5de2e35ee27b64b6817

let overrides = {=}

let additions =
      { jquery =
          mkPackage
            [ "web-dom", "effect", "foreign" ]
            "https://github.com/purescript-contrib/purescript-jquery.git"
            "v5.0.0"
      , nodetrout = ../purescript-nodetrout/spago.dhall as Location
      }

in  upstream // overrides // additions

Activity

  1. f-f commented on Oct 25, 2019

    @f-f
    Member

    @nsaunders great catch! Fix is up in #470, though we'll need to wait until #469 goes in for CI to pass

  2. nsaunders commented on Oct 27, 2019

    @nsaunders
    Author

    Awesome, thanks @f-f!

  3. f-f commented on Oct 27, 2019

    @f-f
    Member

    You're welcome 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions