Skip to content

Reset cursor position on rebuild with --clear-screen --watch - #466

Merged
jhrcek merged 2 commits into
masterfrom
clearScreen
Oct 26, 2019
Merged

jhrcek merged 2 commits into
masterfrom
clearScreen

Conversation

@jhrcek

@jhrcek jhrcek commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

Description of the change

Fix for #465

Checklist:

  • Added the change to the "Unreleased" section of the changelog
  • Added some example of the new feature to the README
  • Added a test for the contribution (if applicable)

@vlatkoB

vlatkoB commented Oct 25, 2019

Copy link
Copy Markdown

Strange that so many tests are failing on such a small change.

@jhrcek

jhrcek commented Oct 25, 2019

Copy link
Copy Markdown
Contributor Author

The CI is failing because of the package-set / purs compiler version update, not because my change. Leaving this pr as is now until Fabrizio comes from vacation and takes a look at that first.

@f-f f-f left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhrcek looks great, thanks!

I confirm that CI is breaking because we need to upgrade the PureScript version, which is happening in #469

@jhrcek
jhrcek merged commit 99dcf4a into master Oct 26, 2019
@mergify
mergify Bot deleted the clearScreen branch October 26, 2019 06:03
Benjmhart pushed a commit to Benjmhart/spago that referenced this pull request Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants