Repository navigation
Add __bool__, __iter__ and __len__ to TableFinder - #5153
Open
felipdsa21 wants to merge 3 commits into
Open
felipdsa21 wants to merge 3 commits into
felipdsa21 wants to merge 3 commits into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
veget-able
approved these changes
Oct 12, 2026
veget-able
left a comment
veget-able
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this is a handy addition. I pushed one small commit on top of your branch that adds a changelog line and documents the three methods in docs/page.rst, so the change is visible to users. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TableFinderclass (returned byPage.find_tables()) is extended so it can be used like the list of tables it holds:len(page.find_tables())returns the number of tables found. Before, it raisedTypeError.bool(page.find_tables())isFalsewhen no tables were found. Before, it was alwaysTrue, soif page.find_tables():never skipped pages without tables.for tab in page.find_tables():iterates over.tables..tablesand indexing work as before.Adds
test_table_finder_len_bool_iter()totests/test_tables.py. It checks all three methods on a page with three tables (test_3179.pdf) and on a page with none (battery-file-22.pdf).