Skip to content

Consistent changelogs for all specs - #1464

Merged
pradyunsg merged 1 commit into
pypa:mainfrom
jeanas:standard-changelogs
Dec 22, 2023
Merged

pradyunsg merged 1 commit into
pypa:mainfrom
jeanas:standard-changelogs

Conversation

@jeanas

@jeanas jeanas commented Dec 22, 2023 •

Copy link
Copy Markdown
Contributor

@jeanas
jeanas requested a review from pfmoore December 22, 2023 15:46
@jeanas

jeanas commented Dec 22, 2023

Copy link
Copy Markdown
Contributor Author

@encukou

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but would like to get more opinions.

@brettcannon

Copy link
Copy Markdown
Member

I'm good with the change!

@pradyunsg

Copy link
Copy Markdown
Member

Clicking auto-merge eagerly on this since, IIUC, it'll wait on the outstanding reviews.

If it does not, apologies and please do review this post-merge and I (or @jeanas, should they be willing 😅) will address that feedback.

@pradyunsg
pradyunsg added this pull request to the merge queue Dec 22, 2023
Merged via the queue into pypa:main with commit 0b7879f Dec 22, 2023
@jeanas
jeanas deleted the standard-changelogs branch December 22, 2023 21:46
@jeanas

jeanas commented Dec 22, 2023

Copy link
Copy Markdown
Contributor Author

Clicking auto-merge eagerly on this since, IIUC, it'll wait on the outstanding reviews.

Well, you just merged the change, since it had already been approved by @webknjaz, @brettcannon and yourself (I don't understand GitHub well enough to tell what exactly the condition for auto-merge to trigger is). 🙂

If it does not, apologies and please do review this post-merge and I (or @jeanas, should they be willing 😅) will address that feedback.

Sure, I will happily apply further feedback (although I may have less time temporarily due to Christmas etc.).

@pradyunsg

Copy link
Copy Markdown
Member

I don't understand GitHub well enough to tell what exactly the condition for auto-merge to trigger is

Evidently, same. 😅

@webknjaz

Copy link
Copy Markdown
Member

The branch protection requires just one approval from anyone. So it goes through unless blocked. No biggie, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add changelogs to all standards

4 participants