Repository navigation
Run class cleanups when the database setup or teardown of a test fails - #1328
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
If _pre_setup() or _post_teardown() raised, tearDownClass() and doClassCleanups() were skipped. Django removes its database access guards in a class cleanup, so they stayed on the connections and later tests using another alias failed with DatabaseOperationForbidden.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
_pre_setup()or_post_teardown()raises in_django_db_helper,tearDownClass()anddoClassCleanups()are skipped. Django removes its database access guards in a class cleanup, so they stay on the connections and every later test that may use another alias fails:test_bfails withDatabaseOperationForbidden: Database queries to 'other' are not allowed in this test, although the only broken test istest_a.The cleanups now run in
finallyblocks, in the order unittest runs them.