Repository navigation
Don't look up the template origin for ignored undefined variables - #1329
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
With --fail-on-template-vars the origin is found by inspecting the stack. That was also done for tests marked ignore_template_errors, where the message is never used.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--fail-on-template-vars,InvalidVarException.__mod__looks up the template origin withinspect.stack()before it checks whether it should fail at all. In a test markedignore_template_errorsthe message is thrown away, but the stack is still inspected for every undefined variable.A template that renders an undefined variable 2000 times in a loop takes 1.9 s in such a test here, and 0.01 s with this change (also 0.01 s without the flag).