Repository navigation
Don't set up monkeypatch and django_db_blocker for every test - #1330
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
Two autouse fixtures took them as arguments, so pytest resolved them for every test, although only tests marked ignore_template_errors and unittest classes with databases use them. Request them where they are needed instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_template_string_if_invalid_markertakesmonkeypatchand_django_setup_unittesttakesdjango_db_blockeras arguments. Both are autouse, so pytest resolves the two fixtures for every test, and creates and tears down aMonkeyPatcheach time. They are only used for tests markedignore_template_errorsand for unittest classes withdatabases.Requesting them with
getfixturevalue()where they are needed saves about 8% of the function calls for a file with 5000 empty tests (26.5M to 24.3M under cProfile) and about 5% of the CPU time.