Skip to content

Don't do JSON as a database, kids. - #700

Merged
sue-m-oh merged 4 commits into
mainfrom
json-is-not-good-database
Apr 28, 2022
Merged

sue-m-oh merged 4 commits into
mainfrom
json-is-not-good-database

Conversation

@Xithrius

@Xithrius Xithrius commented Mar 21, 2022 •

Copy link
Copy Markdown
Contributor

It won't do you well.

Finishes off one of the check marks for #695.

@Xithrius Xithrius added area: frontend Related to site content and user interaction priority: 3 - low Low Priority type: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve labels Mar 21, 2022
@Xithrius
Xithrius requested a review from jchristgit March 21, 2022 08:52
@netlify

netlify Bot commented Mar 21, 2022 •

Copy link
Copy Markdown

✅ Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit 5bd44f7
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/626ad9d57659460008ec2dfe
😎 Deploy Preview https://deploy-preview-700--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coveralls

coveralls commented Mar 21, 2022 •

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 5bd44f7 on json-is-not-good-database into 08f2e12 on main.

@Shom770 Shom770 mentioned this pull request Mar 21, 2022
18 tasks done
@Xithrius Xithrius added type: feature New feature or request priority: 2 - normal Normal Priority and removed type: enhancement Changes or improvements to existing features priority: 3 - low Low Priority labels Mar 22, 2022

@jchristgit jchristgit left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This migrates the pin, so I'm approving.

That said, I do think the content is a bit weird, since the second paragraph makes the following points:

  • "No redundancy built into JSON"
  • "No built in ways to keep it safe and backed up"
  • "No built in encryption", with some inclusion of GDPR

This, to me, sounds like standard databases offer any of that, out of the box. Unfortunately there's no magic setting or function in PostgreSQL where I can go SELECT spin_up_slaves(3), SELECT perform_encrypted_redundant_backup() and SELECT pg_encrypt_harddrive(), those are all still left to the operator.

Regardless, this makes some good points, so let's get it in.

@jchristgit

Copy link
Copy Markdown
Contributor

Let's maybe revise the content later, but migrate the pin here first.

@Bluenix2 Bluenix2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my only complaint. Thanks for the PR Xithrius (and Mina for finishing it 💯)!

@sue-m-oh
sue-m-oh merged commit d25d4ed into main Apr 28, 2022
@sue-m-oh
sue-m-oh deleted the json-is-not-good-database branch April 28, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: frontend Related to site content and user interaction priority: 2 - normal Normal Priority s: needs review Author is waiting for someone to review and approve type: feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants