Created a guide on how to run a bot with Docker and setup GitHub Actions for CI by Exenifix · Pull Request #746 · python-discord/site

Exenifix · 2022-07-18T20:26:47Z

No description provided.

netlify · 2022-07-18T20:26:52Z

✅ Deploy Preview for pydis-static ready!

Name	Link
🔨 Latest commit	`45fdd79`
🔍 Latest deploy log	https://app.netlify.com/sites/pydis-static/deploys/638c75d2aeafa0000aca353a
😎 Deploy Preview	https://deploy-preview-746--pydis-static.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

coveralls · 2022-07-18T20:37:23Z

Coverage remained the same at 100.0% when pulling 45fdd79 on Exenifix:main into 708012c on python-discord:main.

Robin5605

Thanks for the PR, could you fix up some of the issues I commented on? Thanks!

Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>

Exenifix · 2022-07-24T09:16:25Z

I fixed most of the issues, thanks for the review

Robin5605

Thanks for fixing it up! LGTM

Xithrius

That's some good stuff right there.

vivekashok1221

Small suggestion.

…hosting-guide.md Co-authored-by: Vivek Ashokkumar <vivekashok1221@gmail.com>

shtlrs

Some very small nit changes.

Other than that, great work !

shtlrs · 2022-09-22T07:44:38Z

+
+## You will learn
+
+- how to write Dockerfile


Nit: I think all these sentences should begin with a capital letter

Thanks for this suggestion, but I consider them kind of continuations of the sentence started in the header, not the standalone sentences. Not sure if this is proper, but I am going to leave it as it is for now, except I am going to bring "how to" out to the header because it is in every item.

Exenifix · 2022-09-22T12:37:55Z

Sorry for this mess, for some reason github only allows to request only one review now.

Robin5605 · 2022-10-16T20:29:55Z

Hey! Would you mind working on @vivekashok1221's review? I think we can get it merged once that's done 😄

Exenifix · 2022-10-17T04:00:16Z

I have already implemented what they requested, they just haven't reviewed it yet.

Exenifix · 2022-12-01T20:40:13Z

Hey, @Robin5605, seems like they are not going to re-review this, as 4 months have passed since the changes they suggested have been implemented. Is there a way to continue working with this PR without their approval?

vivekashok1221 · 2022-12-03T14:13:08Z

Forgot all about this, thought it'd be merged by now.
Please allow me to give this a once-over.

vivekashok1221

Sorry for delaying my review, was/is busy with life and stuff :(

Exenifix · 2022-12-04T10:09:08Z

Thanks, I will fix these soon

…hosting-guide.md Co-authored-by: Vivek Ashokkumar <vivekashok1221@gmail.com>

Exenifix · 2022-12-04T10:28:00Z

All the requested things were fixed I think, thanks for your review @vivekashok1221

jchristgit · 2022-12-06T22:29:42Z

Thank you for the pull request 🔥 Into master we go 🎉 Good work team 🥳

Create docker-hosting-guide.md

2d4ba1a

Updated a docker guide

2f7aeca

Robin5605 requested changes Jul 20, 2022

View reviewed changes

Exenifix and others added 5 commits July 24, 2022 11:27

Additional explanation about docker base image

ab6c82e

Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>

Changed "requirements" to external dependencies

ff10aa5

Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>

Removed unnecessary combination

1388628

Co-authored-by: Robin <74519799+Robin5605@users.noreply.github.com>

Updated the guide as requested

fa7143f

Guide linting applied

2fbc05d

Exenifix requested a review from Robin5605 July 26, 2022 10:08

Robin5605 approved these changes Jul 29, 2022

View reviewed changes

Xithrius added area: frontend Related to site content and user interaction type: feature New feature or request priority: 2 - normal Normal Priority labels Jul 31, 2022

Xithrius approved these changes Jul 31, 2022

View reviewed changes

fisher60 reviewed Jul 31, 2022

View reviewed changes

Comment thread pydis_site/apps/content/resources/guides/python-guides/docker-hosting-guide.md Resolved

vivekashok1221 requested changes Jul 31, 2022

View reviewed changes

Comment thread pydis_site/apps/content/resources/guides/python-guides/docker-hosting-guide.md Resolved

Exenifix and others added 4 commits August 1, 2022 10:11

Update pydis_site/apps/content/resources/guides/python-guides/docker-…

507676a

…hosting-guide.md Co-authored-by: Vivek Ashokkumar <vivekashok1221@gmail.com>

Added additional explanation about branch name

0f94b8e

Some grammar mistakes fix

b572522

Linting applied

a8b5cd6

Exenifix requested review from fisher60 and vivekashok1221 August 1, 2022 07:25

Robin5605 mentioned this pull request Sep 5, 2022

Migrating #discord-bots pins to the site #695

Closed

18 tasks done

shtlrs reviewed Sep 22, 2022

View reviewed changes

Exenifix and others added 2 commits September 22, 2022 15:34

Minor change to "you will learn" section

67ba14c

Merge branch 'main' into main

634d0ee

Exenifix removed the request for review from vivekashok1221 September 22, 2022 12:35

Exenifix requested review from shtlrs and vivekashok1221 and removed request for fisher60, shtlrs and vivekashok1221 September 22, 2022 12:35

shtlrs approved these changes Sep 22, 2022

View reviewed changes

Merge branch 'main' into main

de3b6a4

Robin5605 added the s: waiting for author Waiting for author to address a review or respond to a comment label Oct 16, 2022

Exenifix requested a review from vivekashok1221 October 17, 2022 04:01

Merge branch 'main' into main

8b5b8ff

vivekashok1221 requested changes Dec 3, 2022

View reviewed changes

Exenifix and others added 5 commits December 4, 2022 13:10

Update pydis_site/apps/content/resources/guides/python-guides/docker-…

ce18f5a

…hosting-guide.md Co-authored-by: Vivek Ashokkumar <vivekashok1221@gmail.com>

Update pydis_site/apps/content/resources/guides/python-guides/docker-…

09d6de4

…hosting-guide.md Co-authored-by: Vivek Ashokkumar <vivekashok1221@gmail.com>

Update pydis_site/apps/content/resources/guides/python-guides/docker-…

0574eb2

…hosting-guide.md Co-authored-by: Vivek Ashokkumar <vivekashok1221@gmail.com>

Merge branch 'python-discord:main' into main

92a9669

Updates for docker hosting guide

45fdd79

Exenifix requested a review from vivekashok1221 December 4, 2022 10:28

vivekashok1221 approved these changes Dec 4, 2022

View reviewed changes

jchristgit merged commit 2ecc3a9 into python-discord:main Dec 6, 2022

Conversation

Exenifix commented Jul 18, 2022

Uh oh!

netlify Bot commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for pydis-static ready!

Uh oh!

coveralls commented Jul 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Robin5605 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Exenifix commented Jul 24, 2022

Uh oh!

Robin5605 left a comment

Choose a reason for hiding this comment

Uh oh!

Xithrius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vivekashok1221 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shtlrs left a comment

Choose a reason for hiding this comment

Uh oh!

shtlrs Sep 22, 2022

Choose a reason for hiding this comment

Uh oh!

Exenifix Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Exenifix commented Sep 22, 2022

Uh oh!

Robin5605 commented Oct 16, 2022

Uh oh!

Exenifix commented Oct 17, 2022

Uh oh!

Exenifix commented Dec 1, 2022

Uh oh!

vivekashok1221 commented Dec 3, 2022

Uh oh!

vivekashok1221 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Exenifix commented Dec 4, 2022

Uh oh!

Exenifix commented Dec 4, 2022

Uh oh!

jchristgit commented Dec 6, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

netlify Bot commented Jul 18, 2022 •

edited

Loading

coveralls commented Jul 18, 2022 •

edited

Loading

Exenifix Sep 22, 2022 •

edited

Loading