Skip to content

Decompressor uses inexistent dictionary API #215

Open
#229
Open
Decompressor uses inexistent dictionary API#215
#229

Description

@illia-v
illia-v
opened on Nov 21, 2025

While I was working on #207, I noticed that the decompressor class allows passing a custom dictionary, but the functionality is not working because lib.BrotliDecoderSetCustomDictionary was dropped since v1.0.9.0.

brotlicffi/src/brotlicffi/_api.py

Lines 369 to 376 in 75ac969

if dictionary:
self._dictionary = ffi.new("uint8_t []", dictionary)
self._dictionary_size = len(dictionary)
lib.BrotliDecoderSetCustomDictionary(
self._decoder,
self._dictionary_size,
self._dictionary
)

AttributeError: cffi library '_brotlicffi' has no function, constant or global variable named 'BrotliDecoderSetCustomDictionary'. Did you mean: 'BrotliDecoderAttachDictionary'?

It may be possible to use BrotliDecoderAttachDictionary instead of BrotliDecoderSetCustomDictionary.

This functionality has been broken for a few releases, so I hope it doesn't block releasing v1.2.0.0.

Activity

  1. sethmlarson commented on Nov 22, 2025

    @sethmlarson
    sethmlarson
    on Nov 22, 2025
    Member

    Good catch, this also signals to me that this feature is indeed used by almost no-one. If anyone submits a PR and I can make a 1.2.0.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions