Skip to content

Fixed minor typo pair in json/__init__.py docstrings - #161261

Merged
StanFromIreland merged 3 commits into
python:mainfrom
Zkaij:main
Nov 4, 2026
Merged

StanFromIreland merged 3 commits into
python:mainfrom
Zkaij:main

Conversation

@Zkaij

@Zkaij Zkaij commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Trivial changes, like fixing a typo, do not need an issue.

👉🏻 👉🏻

@python-cla-bot

python-cla-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Nov 3, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz

picnixz commented Nov 3, 2026

Copy link
Copy Markdown
Member

Is the RST (online) affected as well? (or are there other typos in the docstrings of this module?)

@Zkaij

Zkaij commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Unfamiliar with that term, even after a Google search. If you mean the ReadTheDocs site, then no, as far as I can tell. Otherwise, could you point me more specifically to what you mean?

@StanFromIreland

Copy link
Copy Markdown
Member

Bénédikt meant "Restructured Text", which is the format we use for the documentation seen at docs.python.org. It lives in Doc/.

@Zkaij

Zkaij commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

Got it, thanks. :) I found that term, but couldn't connect it to the docs.

Checking the docs for the relevant part: funnily enough, no, it's written correctly there.

@StanFromIreland StanFromIreland left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please fix:

$ gg "an RecursionError"
Lib/json/encoder.py:        prevent an infinite recursion (which would cause an RecursionError).

@Zkaij

Zkaij commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Well spotted—done.

@StanFromIreland
StanFromIreland merged commit 4383968 into python:main Nov 4, 2026
57 checks passed
@StanFromIreland StanFromIreland added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 4, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @Zkaij for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @Zkaij for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 4, 2026

Copy link
Copy Markdown

GH-161351 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 4, 2026
@bedevere-app

bedevere-app Bot commented Nov 4, 2026

Copy link
Copy Markdown

GH-161352 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 4, 2026
StanFromIreland pushed a commit that referenced this pull request Nov 4, 2026
(cherry picked from commit 4383968)

Co-authored-by: Fie <40601523+Zkaij@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants