Skip to content

gh-96398: python3: use cc_basename instead of CC when checking binary name - #96399

Closed
kanavin wants to merge 2 commits into
python:mainfrom
kanavin:fix-cc
Closed

kanavin wants to merge 2 commits into
python:mainfrom
kanavin:fix-cc

Conversation

@kanavin

@kanavin kanavin commented Aug 29, 2022 •

Copy link
Copy Markdown
Contributor

When paths contain "clang"/"gcc"/"icc", they might be part of $CC
for example because of the "--sysroot" parameter. That could cause
judgement error about clang/gcc/icc compilers. e.g.

when "icc" is containded in working path, below errors are reported when
compiling python3:
x86_64-wrs-linux-gcc: error: strict: No such file or directory
x86_64-wrs-linux-gcc: error: unrecognized command line option '-fp-model'

When paths contain "clang"/"gcc"/"icc", they might be part of $CC
for example because of the "--sysroot" parameter. That could cause
judgement error about clang/gcc/icc compilers. e.g.

when "icc" is containded in working path, below errors are reported when
compiling python3:
x86_64-wrs-linux-gcc: error: strict: No such file or directory
x86_64-wrs-linux-gcc: error: unrecognized command line option '-fp-model'
@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@kanavin

kanavin commented Aug 29, 2022

Copy link
Copy Markdown
Contributor Author

Looks like the failing test is not caused by the change here?

@kanavin

kanavin commented Sep 10, 2024

Copy link
Copy Markdown
Contributor Author

Fxied in fecb9fa

@kanavin kanavin closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants