Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The template, scrolling handlers, and responsive styles are consistent, with no unresolved blocking issues.
No open issues 🎉
What changed in this PR
This PR reduces mobile header space by hiding the Python Network menu on small screens while preserving the skip-to-content link.
Changes:
- Hide the top menu below 640px and remove adjacent borders.
- Remove obsolete Python Network jump links, handlers, and styles.
- Update footer links and smooth scrolling to target
#top.
| File | Description |
|---|---|
templates/base.html |
Remove network jump links and retarget footer links. |
static/js/script.js |
Remove obsolete handlers and update back-to-top scrolling. |
static/css/style.css |
Remove unused jump-link styling. |
static/css/mq.css |
Hide the mobile top menu and remove obsolete responsive styling. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When visiting https://www.python.org on mobile, the top menu takes up around half the screen:
This is quite annoying, and I don't remember ever clicked any of those links.
We could have it collapsed by default, but I think we could just remove it instead for mobile.