Errors in forks break non HTML pages #424

Activity

1. hroncok

   added

   bug

   code

   on Jul 1, 2018
2. hroncok

   changed the title [-]Errors in forks brek non HTML pages[/-] [+]Errors in forks break non HTML pages[/+] on Jul 1, 2018
3. hroncok commented on Jul 1, 2018

   

   hroncok

   on Jul 1, 2018

   MemberAuthor

   More actions

   For the calendar particularly this is being handled in

   naucse.python.cz/naucse/views.py

   Lines 825 to 834 in 71cbde9

   	logger.error("There was an error rendering url %s for course '%s'", request.path, course.slug)
   	logger.exception(e)
   	return render_template(
   	"error_in_fork.html",
   	malfunctioning_course=course,
   	edit_info=get_edit_info(course.edit_path),
   	faulty_page="calendar",
   	root_slug=model.meta.slug,
   	travis_build_id=os.environ.get("TRAVIS_BUILD_ID"),
   	)

   We need to return something that has correct content type.
4. encukou commented on Jul 1, 2018

   

   encukou

   on Jul 1, 2018

   Member

   More actions

   It's actually in the .ics route.

   naucse.python.cz/naucse/views.py

   Lines 901 to 910 in 71cbde9

   	logger.error("There was an error rendering url %s for course '%s'", request.path, course.slug)
   	logger.exception(e)
   	return render_template(
   	"error_in_fork.html",
   	malfunctioning_course=course,
   	edit_info=get_edit_info(course.edit_path),
   	faulty_page="calendar",
   	root_slug=model.meta.slug,
   	travis_build_id=os.environ.get("TRAVIS_BUILD_ID"),
   	)

   To handle this in a static site we'd need an iCal error page. I don't think that's possible :(
5. hroncok commented on Jul 1, 2018

   

   hroncok

   on Jul 1, 2018

   MemberAuthor

   More actions

   Right. Well, we can set the content type as a dirty workaround. The static site will then download an ics file with HTML content which isn't great, but at least it would build. Later, we can change the error to plaintext maybe.
6. hroncok commented on Jul 1, 2018

   

   hroncok

   on Jul 1, 2018

   Last edited by hroncok

   MemberAuthor

   More actions

   There's a power outage, so I'm on battery and cell data, so don't expect an actual fix/workaround from me any time soon (as it involves pulling docker images etc.).
7. encukou commented on Jul 1, 2018

   

   encukou

   on Jul 1, 2018

   Member

   More actions

   ACK, I'll do the workaround.
8. encukou

   added a commit that references this issue on Jul 1, 2018

   Work around for error in calendars

   ...

   06711a5
9. encukou commented on Feb 8, 2019

   

   encukou

   on Feb 8, 2019

   Member

   More actions

   No idea how we are supposed to handle this, but the current implementation breaks the entire build if this happens.

   Current implementation breaks the entire build if this happens, as do any errors.
   The plan is that a course will show the last successful build; errors like this will prevent that one course from updating.
   Also, dependencies for new courses are locked using pipenv.

   See #494 for a high-level plan
10. encukou

    closed this as completedon Feb 8, 2019