Skip to content

test(java): fix two tests that fail against release native builds - #121

Open
ChristopherWirt wants to merge 1 commit into
developfrom
cwirt/fix-develop-tests
Open

ChristopherWirt wants to merge 1 commit into
developfrom
cwirt/fix-develop-tests

Conversation

@ChristopherWirt

Copy link
Copy Markdown
Collaborator

vortex-build's release of develop failed with RUN_TESTS=true (vortex-build main #59). qc40, qc51 and qc60 were released with tests off.

VortexV1FallbackTest.readsMissingColumnsWithCodegen

ExpressionReachabilityTest.temporaryLiteralInputsSurviveNativeCalls

  • Its child JVM ran out of heap, but only with a release libvortex_jni (CI's); a debug build passes.
  • A class histogram shows CleanerImpl$PhantomCleanableRef and Expression lambdas filling the 32 MB heap: the optimized loop creates expressions faster than the Cleaner releases them.
  • The GC thread already forces collections, so the child gets 256 MB.

Both pass locally against a release libvortex_jni (the reachability test 5 of 5).

🤖 Generated with Claude Code

- VortexV1FallbackTest.readsMissingColumnsWithCodegen reads two files with
  different columns, so it must opt into vortex.mergeSchema, which defaults
  to false since #105.
- ExpressionReachabilityTest's child JVM ran out of heap with an optimized
  native library: the loop creates expressions faster than the Cleaner
  releases them, and their cleanables filled the 32 MB heap. The GC thread
  supplies the GC pressure, so the child now gets 256 MB.

Both failed on vortex-build's release build with RUN_TESTS, and both now
pass locally against a release libvortex_jni.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Christopher Wirt <cwirt@quantcast.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant