Repository navigation
test(java): fix two tests that fail against release native builds - #121
Open
ChristopherWirt wants to merge 1 commit into
Open
ChristopherWirt wants to merge 1 commit into
ChristopherWirt wants to merge 1 commit into
Conversation
- VortexV1FallbackTest.readsMissingColumnsWithCodegen reads two files with different columns, so it must opt into vortex.mergeSchema, which defaults to false since #105. - ExpressionReachabilityTest's child JVM ran out of heap with an optimized native library: the loop creates expressions faster than the Cleaner releases them, and their cleanables filled the 32 MB heap. The GC thread supplies the GC pressure, so the child now gets 256 MB. Both failed on vortex-build's release build with RUN_TESTS, and both now pass locally against a release libvortex_jni. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christopher Wirt <cwirt@quantcast.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vortex-build's release of
developfailed withRUN_TESTS=true(vortex-build main #59). qc40, qc51 and qc60 were released with tests off.VortexV1FallbackTest.readsMissingColumnsWithCodegenvortex.mergeSchemadefaults to false, so the read infers one file's schema and the extra column is missing.ExpressionReachabilityTest.temporaryLiteralInputsSurviveNativeCallslibvortex_jni(CI's); a debug build passes.CleanerImpl$PhantomCleanableRefandExpressionlambdas filling the 32 MB heap: the optimized loop creates expressions faster than the Cleaner releases them.Both pass locally against a release
libvortex_jni(the reachability test 5 of 5).🤖 Generated with Claude Code