Repository navigation
Return finite closest points for parallel and coincident lines - #304
Open
kaushikgunasekaren wants to merge 2 commits into
Open
kaushikgunasekaren wants to merge 2 commits into
kaushikgunasekaren wants to merge 2 commits into
Conversation
Updated handling of parallel lines in closest point calculation.
Add tests for closest-point queries on parallel lines and ensure finite results.
kaushikgunasekaren
requested review from
petercorke and
taughz
as code owners
November 14, 2026 17:38
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Line3.closest_to_line()divides by the squared cross-product norm even for parallel or coincident lines. Both the closest point and distance become NaN, including in sequence/broadcast queries.Fix
Use the existing parallel predicate before that division. For parallel or coincident lines, return the first line's principal point as a representative closest point, together with the existing minimum-distance calculation. Document this choice; the closest point is not unique in these cases. Nonparallel calculations are unchanged.
Validation
git diff --checkpass.This handles the parallel closest-point case, distinct from #224's distance calculation, #232's relation predicates and #273's unique intersection point. AI assistance was used for investigation, implementation and tests. Validated locally without robot hardware.