Repository navigation
Plot vertical planes without dividing by a zero normal component - #309
Open
kaushikgunasekaren wants to merge 2 commits into
Open
kaushikgunasekaren wants to merge 2 commits into
kaushikgunasekaren wants to merge 2 commits into
Conversation
kaushikgunasekaren
requested review from
petercorke and
taughz
as code owners
November 17, 2026 17:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Plane3.plot()always solves for z by dividing by the z component of the normal. Vertical planes therefore produce division warnings and no finite surface. Near-vertical planes can also miss the plotting volume because the z parameterization is poorly conditioned.Fix
Choose the coordinate with the largest absolute normal component as the dependent coordinate. Sample the other two coordinates, solve the plane equation, and clip the solved coordinate to its matching bounds. The existing axes, styling arguments and return behavior stay unchanged.
Validation
AI assistance was used for investigation, implementation and tests. Validated locally without robot hardware.